floor quick-snapshot prune keep to at least 1 - #78460
Closed
aydnOktay wants to merge 2 commits into
Closed
Conversation
keep=0 made dirs[0:] delete every snapshot including one just created by create_quick_snapshot auto-prune. Match _prune_pre_update_backups and floor keep to 1. Co-authored-by: Cursor <cursoragent@cursor.com>
…adapters Defensively read _polling_conflict_recovery_generation via getattr so bare/__new__ adapters cannot AttributeError during progress recording. Co-authored-by: Cursor <cursoragent@cursor.com>
alt-glitch
added
type/bug
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_prune_quick_snapshotskeepto at least 1 (invalid values fall back to the default).keep=0useddirs[0:]and deleted every snapshot, including one just created bycreate_quick_snapshotauto-prune — same safety floor already used by_prune_pre_update_backups._polling_conflict_recovery_generation.