Clamp session.list limit to avoid unbounded fetches - #74784
Closed
aydnOktay wants to merge 1 commit into
Closed
Conversation
Negative or huge limit values on the TUI gateway session.list RPC could over-fetch via SQL and flip Python rows[:limit] into nearly-full results. Clamp to 1-500 while preserving the default of 200. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks — this fixes a verified current-main defect in the TUI session-list RPC. Suggested changes
Automated hermes-sweeper review. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TUI gateway session.list RPC accepted unbounded and negative limit values, which could force oversized SQL fetches and cause Python negative-slice semantics to return nearly the full session list. This change clamps limit to a safe range of 1–500 while preserving the existing default of 200 for the resume picker.