Skip to content

Remove experimental warning on whole-module imports #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtran merged 3 commits into from
Apr 11, 2025
Merged

Remove experimental warning on whole-module imports #6240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ac0927
Remove experimental warning on whole-module imports
jtran Apr 9, 2025
ababffa
Merge branch 'main' into jtran/remove-warning
jtran Apr 10, 2025
734fcd5
Merge branch 'main' into jtran/remove-warning
jtran Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions rust/kcl-lib/src/parsing/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1803,11 +1803,6 @@ fn import_stmt(i: &mut TokenSlice) -> PResult<BoxNode<ImportStatement>> {
end = alias.end;
*selector_alias = Some(alias);
}

ParseContext::warn(CompilationError::err(
SourceRange::new(start, path.end, path.module_id),
"Importing a whole module is experimental, likely to be buggy, and likely to change",
));
}

let path_string = match path.inner.value {
Expand Down Expand Up @@ -4495,21 +4490,9 @@ export fn cos(num: number(rad)): number(_) {}"#;

#[test]
fn warn_import() {
let some_program_string = r#"import "foo.kcl""#;
let (_, errs) = assert_no_err(some_program_string);
assert_eq!(errs.len(), 1, "{errs:#?}");

let some_program_string = r#"import "foo.obj""#;
let (_, errs) = assert_no_err(some_program_string);
assert_eq!(errs.len(), 1, "{errs:#?}");

let some_program_string = r#"import "foo.sldprt""#;
let (_, errs) = assert_no_err(some_program_string);
assert_eq!(errs.len(), 1, "{errs:#?}");

let some_program_string = r#"import "foo.bad""#;
let (_, errs) = assert_no_err(some_program_string);
assert_eq!(errs.len(), 2, "{errs:#?}");
assert_eq!(errs.len(), 1, "{errs:#?}");
}

#[test]
Expand Down
Loading