sync develop#12
Merged
Merged
Conversation
* adding hr_ave_chem_v1 to atmos_cubed_sphere Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
* update atmos_cubed_sphere
…-EMC#610) * Performance optimization of moving nest. * update atmos_model and FV3GFS_io read performance when io_layout=1,1 and allow one to override data integrity checks in FMS restart logic * Add the following HAFS ccpp physics suites (@ChunxiZhang-NOAA and @BinLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml * Update submodule UPP to point its latest develop branch as of 05/18/2022. * Update submodule upp, which has the fix for regional latlon grid crossing the prime meridian. * Only call atmosphere_fill_nest_cpl at the cap driver time steps (coupling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest. * Removed reference to unused variable parent_x. * FV3-related typedefs changes for the Hurricane PBL options * Update submodule ccpp/physics, which added the tc_pbl option in the GFS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling. * Adding upoff as a namelist parameter * Update submodule atmos_cubed_sphere, which has updated the time string in internal tracker output (fort.602, phtcf file). * Restructure moving nest code from atmos_cubed_sphere into FV3 directory. * Rename HAFS_v0 CCPP physics suites to HAFS_V1. * Added namelist flag fv_timers to enable detailed performance timings; defaults to false. * Removed special CMake handling of moving nest files. This causes a switch from 'fp-model source' as they were compiled in atmos_cubed_sphere, to 'fp-model consistent' aligned with the FV3atm tree. Minor rounding differences are noted in forecast results. * Update submodule ccpp/physics and update tc_pbl standard and long names. * Removed ifdef MOVING_NEST, as files are included/excluded by cmake Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov> Co-authored-by: Rusty.Benson <rusty.benson@noaa.gov> Co-authored-by: AndrewHazelton <andrew.hazelton@noaa.gov> Co-authored-by: Biju Thomas <biju.thomas@noaa.gov>
* Enhanced stability of drag_suite module and added diagnostics * Updated standard_names for do_gsl_drag_ls_bl, do_gsl_drag_ss, do_gsl_drag_tofd and ugwp_seq_update * Assumed-shape in gwdps.f * Added logical flag 'ugwp_seq_update' to gfs_physics_nml namelist * Modified calculation of dtfac in drag_suite.F90 and revised various long_name's of diagnostic variables * Removed passage of variables 'ak' and 'bk' to drag_suite -- these are no longer used * Removed unused variables from GFS_typedefs.F90 and added clarifying comments in ccpp-physics
…MC#612) This flag is set to .false.by default. When the user sets it to .true. explicitly in the model_configure file the time dimension in history files will be a record dimension (ie. unlimited)
* MYNNsfc uniform real kind
* Bring in inst_pres_interface for AQM
…-EMC#613) * Hardcoded coarse terrain for moving nest with terrain_smoother=4 * Update HAFSv1 CCPP suites to use the unified ugwp scheme. * Update submodule upp. * Removed debug print statements for terrain_smoother * Fixed bug in calculation of nest halo weights identified by Biju Thomas in DDEBUG=ON builds. * Updated fix to moving nest weight calculations. * Use ind arrays for nest weight calculations. Ensures correct indexing. * Clean up for the fix of using ind arrays for moving-nest weight calculations (from @wramstrom). Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov>
…NOAA-EMC#618) * Use 32bit value for 'missing_value' and '_FillValue' attributes
…EMC#621) * Bug fix for cloud effective radius for convective clouds (HR1)
* Changes to typedefs for RRTMGP refactoring. Updates to prebuild and SDFs. * bugfix to save q state regardless of diagnostic flag, submodule update * optimizing massflux at cloud base based on P8 simulations, submodule update ccpp/physics * Added RRTMGP p8 coupled RT. * Move allocation of RRTMGP DDTs to init. * Removed deprecated SDFs Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
…#622) * fix initialization for moving nest grid
* Six new winter wx diags added to output, accumulated fields added to restart file and changed nsradar_reset, radar_reset to something that makes more sense, that is, nsfullradar_diag and fullradar_diag. Also, added new namelist parameter to use new precip ice density with the NOAH LSM. Code changes to upp also made to include the new winter wx diags.
…nout' (NOAA-EMC#627) * Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' * Updated UGWP diagnostic variable declaration intents in drag_suite.meta
* allow consisten restart file name with date * remove intrm_rst and restart_endfcst in fcst finalize * remove restart_endfcst from fcst grid comp
* Merge pull request NOAA-EMC#67 from dustinswales/accumulated_cleanup: ccpp physocs
… submodule pointer update for NOAA-EMC#462 (NOAA-EMC#634) * add nssl_alphar, nssl_ehw0_in, nssl_ehlw0_in to namelist entries for ensemble perturbationsons * update the standard name for hail/graupel collection efficiency * update the long names for parameters related to NSSL microphysics * update ccpp/physics and ccpp/framework submodule pointers --------- Co-authored-by: Jili Dong <Jili.Dong@noaa.gov>
* add IFI to post * pass w to model & fixes to ccpp/physics changes * send lightning threat indexes to post * upp: remove 444 ltng and add 704 * ccpp/physics: fill ltg*_max with 0 when model is hydrostatic * atmos_cubed_sphere: only send w to model in non-hydrostatic mode, and only if model wants it * disable lightning_threat when hydrostatic, and initialize wgrs * turn off lightning_threat by default since it allocates wgrs and passes w * missing `active = (lightning_threat_indices_enabled)` for wgrd * UPP submodule: correct ifi load on acorn * remove unneeded initialization of ltg*_max in post_fv3 * remove unneeded hydrostatic check from maximum_hourly_diagnostics * fix out-of-bounds access in upp calslr_roebbr * fix another out-of-bounds access and move a message to stdout
* MYNN update * "merge RRFS-SD from the GSL repo to the Community repo" * "include MYNN-EDMF updates from PR NOAA-EMC#630" Co-authored-by: joeolson42 <Joseph.B.Olson@noaa.gov> Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
* Add support for writing restart file on the write grid comp
…NOAA-EMC#633) * Merged RRFS_dev changes needed for changes in the CCPP. * bug fix from @tanyasmirnova for rrfs crashes during restart * Added allocation of rhonewsnow1 array. * Bug fix for NSST input * urface_snow_amount_vardens_over_land is changed to surface_snow_amount_assuming_variable_snow_density_over_land Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov> Co-authored-by: joeolson42 <Joseph.B.Olson@noaa.gov>
…AA-EMC#639) * Make passing of PBL q tendency more general (not dependent on specific PBL scheme) for prog closure * Bugfix for convection (prog closure) and gravity wave drag (for stochastic perturbations) needed for GFS/GEFS prototypes
…-EMC#643) * clean up output_1st_tstep_rst and fix diag time at GEFS restart * change logf file to atm.logf
* Update read interface for RRFS * Read MERRA2 aerosol * Update upp revision to dccb321;Merge aerosol/chemical changes from Kate Zhang. * Modify accsnow and sndepac calculation location
* unified convection * Update some logic for progsigma
* "update to run RRFS with GF"
* Updated flake physics and modified related files * LAKEDEBUG is now clm_lake_debug namelist parameter * fix bugs in salty code and add Caspian & Dead seas * set roughness length over ice & water in clm lake model * bug fixes to get fractional ice working * restart works with FV3_HRRR suite * do not freeze great salt lakes * remove clm_lake_fill_with_zero * FV3_HRRR uses clm lake; new FV3_HRRR_flake for flake * Eliminate an out-of-bounds access in MDLFLD.f in UPP. This UPP bug is triggered by one of the new regression tests. * clm lake is HRRR default, alternative suite with flake * bug fix for 2threads support in conus13km tests --------- Co-authored-by: Yihua.Wu <yihua.wu@noaa.gov> Co-authored-by: Helin Wei <Helin.Wei@noaa.gov>
* update dycore: semi-implicit solver update
…odel LBC processing (NOAA-EMC#646) * update atmos_cubed_sphere to better handle data source for regional model LBC processing
* This PR is created due to the ccpp-physics update for HR2 * PBL, Convection and Microphysics Update
JiliDong-NOAA
added a commit
that referenced
this pull request
Sep 22, 2025
* update ccpp/physics --------- Co-authored-by: jili dong <jili.dong@dlogin08.dogwood.wcoss2.ncep.noaa.gov> Co-authored-by: jili dong <jili.dong@clogin07.cactus.wcoss2.ncep.noaa.gov>
JiliDong-NOAA
added a commit
that referenced
this pull request
Sep 22, 2025
JiliDong-NOAA
added a commit
that referenced
this pull request
Mar 5, 2026
…AA-EMC#1019) * Add 'ebu_smoke' to restart if rrfs_sd is enabled * update ccpp/physics (#10) This PR will restore restart reproducibility of RRFSv1 when using saSAS deep convection and progsigma. The change will add the correct logic when initializing sigmab (the updraft area fraction). Although not being turned on in RRFSv1, saSAS shallow convection is also modified accordingly for consistency. This PR has no impact on warm start runs. * Acsnow restart fix (#11) * fix for snow water equivalent accumulation restart reproducibility * update ccpp/physics * Add write grid comp. restart support for fv_diag.res file * update ccpp/physics * Restart fix (#12) * update ccpp/physics --------- * output sfc spfh to history file * update GFDL_atmos_cubed_sphere * update atmos_cubed_sphere for hailcast * update ccpp/physics to fix C3 compiling error * reverse ccpp-physics and atmos_cubed back to community * update atmos_cubed_sphere and ccpp/physics ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs