parallel netcdf IO#41
Merged
Merged
Conversation
This was referenced Jan 10, 2020
Closed
added 5 commits
January 10, 2020 17:15
Collaborator
|
rad2dg can be deleted from module_write_netcdf.F90 |
Collaborator
|
@junwang-noaa Please delete ESMF_ERR_ABORT define (first 3 lines in a file) from module_write_netcdf.F90 and module_write_netcdf_parallel.F90. This macro is not used. |
added 8 commits
January 24, 2020 17:18
…,jchunk2d) Default is size of array on each write task.
| (/im_dimid,jm_dimid,pfull_dimid,time_dimid/), varids(i), & | ||
| shuffle=.false.,deflate_level=ideflate,& | ||
| chunksizes=(/im,jm,1,1/),cache_size=40*im*jm); NC_ERR_STOP(ncerr) | ||
| chunksizes=(/im,jm,1,1/)); NC_ERR_STOP(ncerr) |
Contributor
There was a problem hiding this comment.
Must two of the chunksizes be 1?
Collaborator
Author
There was a problem hiding this comment.
No, but this seems to be the most common access pattern (reading a 2d horizontal slice).
There was a problem hiding this comment.
Now changed so that chunksize can be specified at run time. Default is to use MPI decompisition size..
Default is now ichunk3d,jchunk3d same as array size on each PE, kchunk3d=nlevs This results in the fastest writes on hera.
…ve, let netcdf library choose defaults.
Contributor
edwardhartnett
left a comment
edwardhartnett
left a comment
There was a problem hiding this comment.
The netcdf parts look OK.
Are there no tests in this repo? Where do you guys do testing?
Collaborator
|
We are doing the tests with FV3 parallel code. Currently we are in the
process of updating regression test. Will talk to you in next weeks on
setting up CI.
Jun
…On Tue, Feb 4, 2020 at 1:08 PM Edward Hartnett ***@***.***> wrote:
***@***.**** commented on this pull request.
The netcdf parts look OK.
Are there no tests in this repo? Where do you guys do testing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TM7Y4VKXNYOQGEUS3DRBGVKHANCNFSM4KFKDGJQ>
.
|
DusanJovic-NOAA
approved these changes
Feb 4, 2020
|
I am OK with this PR as is. |
Collaborator
|
Thanks, Jeff and Ed for reviewing the code.
…On Tue, Feb 4, 2020 at 1:46 PM Jeff Whitaker ***@***.***> wrote:
I am OK with this PR as is.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#41>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TOOEM4LLVU72637VCDRBGZXRANCNFSM4KFKDGJQ>
.
|
climbfuji
added a commit
to climbfuji/fv3atm
that referenced
this pull request
Apr 14, 2020
…tc_hwrf-physics dtc/hwrf-physics: merge HWRF saSAS with GFS version, update to a more recent version of fv3atm from EMC develop
jkbk2004
pushed a commit
that referenced
this pull request
Mar 15, 2023
…er update for #462 (#634) * add nssl_alphar, nssl_ehw0_in, nssl_ehlw0_in to namelist entries for ensemble perturbationsons * update the standard name for hail/graupel collection efficiency * update the long names for parameters related to NSSL microphysics * update ccpp/physics and ccpp/framework submodule pointers --------- Co-authored-by: Jili Dong <Jili.Dong@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this enables parallel IO for netcdf output - set 'netcdf_parallel' for output_file in model_configure. Works for compressed writes.
TODO: add ifdef's around parallel code sections so parallel versions of netcdf/hdf5 will not be requiredTo compile without netcdf parallel support, use
-DNO_PARALLEL_NETCDF#23
Supersedes #19