adding hr_ave_chem_v1 to atmos_cubed_sphere#608
Merged
Conversation
12 tasks
Collaborator
|
cubed_sphere pr was merged. @JianpingHuang-NOAA can you update submodule pointer and revert branch in gitmodules? |
DusanJovic-NOAA
approved these changes
Dec 7, 2022
BrianCurtis-NOAA
approved these changes
Dec 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
to update atmos_cubed_sphere with online-calculation and writing of chemical species
Testing
How were these changes tested?
Test was done on WCOSS2
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes
Have the ufs-weather-model regression test been run? On what platform?
Done on WCOSS2
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Please commit the regression test log files in your ufs-weather-model branch
Dependencies
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
NOAA-GFDL/GFDL_atmos_cubed_sphere#226
ufs-community/ufs-weather-model#1513