Smoke, dust, and MYNN updates#635
Merged
Merged
Conversation
35 tasks
grantfirl
reviewed
Mar 23, 2023
grantfirl
reviewed
Mar 23, 2023
grantfirl
reviewed
Mar 23, 2023
…o be turned on to print it
37 tasks
grantfirl
reviewed
Mar 23, 2023
Collaborator
|
The GFS_typedefs-related changes look fine to me. I'll approve once you've finished addressing whatever comments you feel need to be addressed. |
Contributor
Author
|
@grantfirl - I just merged changes from @haiqinli to fix the problems you found, and I updated to the top of develop. |
RatkoVasic-NOAA
approved these changes
Mar 24, 2023
Contributor
RatkoVasic-NOAA
left a comment
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me.
Collaborator
|
@SamuelTrahanNOAA ufs-community/ccpp-physics#54 was merged. Sorry for the delay. Please update sub pointers etc. in preparation for merge. |
Collaborator
|
@SamuelTrahanNOAA ccpp pr was merged. can you update ccpp pointer and revert change in gitmodules? |
Contributor
Author
I just did that. |
jkbk2004
approved these changes
Mar 27, 2023
Collaborator
|
@DusanJovic-NOAA can you approve the pr? |
DusanJovic-NOAA
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RRFS-Smoke is improved, cleaned, and rebranded as RRFS-SD. Now with smoke, dust, and coarsepm tracer handling, it adds dry deposition velocity to MYNN-EDMF, updates the smoke/dust direct and indirect feedback. There are bug fixes: switch to non-aerosol-aware in the GF scheme and correct emission bug in FENGSHA.
Also includes changes from #630
These changes are from @haiqinli and @joeolson42.
Issue(s) addressed
ufs-community/ufs-weather-model#1659
Testing
How were these changes tested? Scientific validation in RRFS parallels and regression tests for hera.gnu, hera.intel.
What compilers / HPCs was it tested with? Hera intel & gnu
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes.
Will the code updates change regression test baseline? Yes, due to MYNN updates and smoke/dust/coarsepm updates.
Please commit the regression test log files in your ufs-weather-model branch - Done
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs