HAFSv1 related developments and moving-nesting code restructure by BinLiu-NOAA · Pull Request #610 · NOAA-EMC/ufsatm

BinLiu-NOAA · 2022-12-04T02:18:54Z

Description

Merge HAFSv1 related developments back to FV3ATM develop branch, including:

Moving nesting code restructure (basically moving the moving nesting related source code from FV3 dycore into FV3ATM) and porting moving nesting related code to use fms2_io (from @wramstrom). More details can be seen from Moving Nest Code Restructure and Port to fms2_io NOAA-GFDL/GFDL_atmos_cubed_sphere#227.
Add the upoff as a namelist option for FV3dycore, which is recommended by GFDL colleagues and implemented by (@BijuThomas-NOAA, @wramstrom, @BinLiu-NOAA, et al.)
Fix the storm-following moving-nesting FV3 internal tracker high-resolution tracker output time format (from @BinLiu-NOAA).
For HAFS FV3ATM-HYCOM coupling, update to only downscale SST from FV3ATM parent (received from HYCOM through CMEPS) into its nested domain on the ocean coupling time step. (Mainly from @BinLiu-NOAA, @wramstrom, and @danrosen25).
Add the tc_pbl option for the GFS TKE EDMF PBL scheme (mainly from @chxmoonlight and @AndrewHazelton, from AOML/HRD). More details can be seen from Add the tc_pbl option used by HAFSv1 for GFS TKE EDMF PBL scheme ufs-community/ccpp-physics#27.
Add some additional HAFS related CCPP physics suites (mainly from @ChunxiZhang-NOAA).

Issue(s) addressed

Testing

Regression testing were conducted at the ufs-weather-model level and the HAFS application level. Only HAFS related regression tests get changing results (which is expected). All other regression tests got identical results.

Dependencies

…and allow one to override data integrity checks in FMS restart logic

…hafsv0.3_final Conflicts: atmos_cubed_sphere

…nLiu-NOAA

…nLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml

…_final

…afsv0.3_final

…022.

…hafsv0.3_final

…sing the prime meridian.

…ling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest.

…branch of the hafs-community fork.

…unity/fv3atm into feature/hafsv0.3_final

…FS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling.

…os_cubed_sphere.

…hafs_sync_202210

in internal tracker output (fort.602, phtcf file).

…hafs_sync_202210

…eature/mn_cleanup_202211

…up_202211 Conflicts: ccpp/physics

…itch from 'fp-model source' as they were compiled in atmos_cubed_sphere, to 'fp-model consistent' aligned with the FV3atm tree. Minor rounding differences are noted in forecast results.

wramstrom · 2022-12-08T20:14:28Z

@DusanJovic-NOAA I removed the CMake files in the moving_nest directory and added them to the main CMakeLists.txt in FV3. This makes the structure simpler. Model results with the new setting "fp-model consistent" are slightly different from the old setting of "fp-model source".

DusanJovic-NOAA · 2022-12-08T20:24:12Z

@DusanJovic-NOAA I removed the CMake files in the moving_nest directory and added them to the main CMakeLists.txt in FV3. This makes the structure simpler. Model results with the new setting "fp-model consistent" are slightly different from the old setting of "fp-model source".

Thanks @wramstrom . This is now much cleaner, and easier to maintain. Now that moving_nest directory is no longer (unconditionally) added with add_subdirectory, but the 7 files are conditionally added to the fv3atm target directly, I think there's no need to have #ifdef MOVING_NEST in each of the moving nest modules.

…ommunity/fv3atm into feature/mn_cleanup_202211

…up_202211

…mn_cleanup_202211

…ommunity/fv3atm into feature/mn_cleanup_202211

junwang-noaa · 2022-12-13T14:43:40Z

@BinLiu-NOAA @wramstrom Thanks for making the code changes. The code changes aer clean. One more question, since the moving nest calls are now moved to atmo_model.F90, will this have big impact to the results since previously the moving nest subroutines are called within dycore?

wramstrom · 2022-12-13T14:46:59Z

@junwang-noaa The relocation of the moving_nest directory did not change the results when compiled with the exact same compiler options; forecast results were bitwise identical. However, the settings for "fp-model" are different in the FV3 directory vs. the atmos_cubed_sphere model. We have moved over to use the FV3 settings for the moving_nest directory, so there are small differences in the results due to different rounding of floating point numbers.

grantfirl · 2022-12-14T14:27:32Z

@jkbk2004 @BinLiu-NOAA ufs-community/ccpp-physics#27 has been merged. It looks like NOAA-GFDL/GFDL_atmos_cubed_sphere#227 needs to be merged before .gitmodules is reverted and submodule pointers are updated here.

Note: Need to update submodule atmos_cubed_sphere once the PR is merged.

…ommunity/fv3atm into feature/mn_cleanup_202211

jkbk2004 · 2022-12-14T16:11:56Z

@grantfirl @BinLiu-NOAA yes, I asked NOAA-GFDL/GFDL_atmos_cubed_sphere#227 to be merged.

jkbk2004 · 2022-12-14T21:55:34Z

@BinLiu-NOAA the cubed sphere pr was merged. can you update the submodule pointer?

BinLiu-NOAA · 2022-12-15T03:14:17Z

@jkbk2004, submodule updated now. Thanks!

BinLiu-NOAA and others added 30 commits April 14, 2022 21:22

Update submodule atmos_cubed_sphere.

f126b8f

Performance optimization of moving nest.

ab314b4

Moving nest performance optimization stage 2.

bf80a91

update gitmodules and hash for atmos_cubed_sphere

b4e6b97

update atmos_model and FV3GFS_io read performance when io_layout=1,1 …

01c494a

…and allow one to override data integrity checks in FMS restart logic

Merge branch 'NOAA-EMC:develop' into emc_io_fixes

bcbe661

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

72265ba

…hafsv0.3_final Conflicts: atmos_cubed_sphere

Add the following HAFS ccpp physics suites (@ChunxiZhang-NOAA and @Bi…

18fffe3

…nLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml

Merge remote-tracking branch 'upstream/develop' into feature/hafsv0.3…

d0b8ca8

…_final

Merge remote-tracking branch 'remotes/RB/emc_io_fixes' into feature/h…

1dc7c3f

…afsv0.3_final

Update submodule UPP to point its latest develop branch as of 05/18/2…

725fe8e

…022.

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

637d972

…hafsv0.3_final

Update submodule upp, which has the fix for regional latlon grid cros…

63b3f23

…sing the prime meridian.

Only call atmosphere_fill_nest_cpl at the cap driver time steps (coup…

324924f

…ling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest.

Removed reference to unused variable parent_x.

7f7e9f5

Update to point submodule ccpp/physics to the feature/hafsv0.3_final …

003b0f9

…branch of the hafs-community fork.

FV3-related typedefs changes for the Hurricane PBL options

9d6d138

Merge branch 'feature/hafsv0.3_final' of https://github.com/hafs-comm…

186342f

…unity/fv3atm into feature/hafsv0.3_final

Update submodule ccpp/physics, which added the tc_pbl option in the G…

4c42e4a

…FS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling.

Update to point the support/HAFS branch for upp, ccpp-physics and atm…

f7cd326

…os_cubed_sphere.

Update submodules of atmos_cubed_sphere, ccpp/physics, upp.

1121f57

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

edc9ddd

…hafs_sync_202210

Adding upoff as a namelist parameter

3c270f8

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

c29f113

…hafs_sync_202210

Update submodule atmos_cubed_sphere, which has updated the time string

7ec516c

in internal tracker output (fort.602, phtcf file).

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

a51f970

…hafs_sync_202210

Code cleanup: modularization

698958e

Restructure moving nest code from atmos_cubed_sphere into FV3 directory.

238adfa

Merge remote-tracking branch 'origin/feature/hafs_sync_202210' into f…

0711598

…eature/mn_cleanup_202211

Merge remote-tracking branch 'upstream/develop' into feature/mn_clean…

be026d8

…up_202211 Conflicts: ccpp/physics

Removed special CMake handling of moving nest files. This causes a sw…

61e2f22

…itch from 'fp-model source' as they were compiled in atmos_cubed_sphere, to 'fp-model consistent' aligned with the FV3atm tree. Minor rounding differences are noted in forecast results.

BinLiu-NOAA and others added 6 commits December 9, 2022 19:28

Update submodule ccpp/physics and update tc_pbl standard and long names.

232186e

Removed ifdef MOVING_NEST, as files are included/excluded by cmake

226f693

Merge branch 'feature/mn_cleanup_202211' of https://github.com/hafs-c…

68166f5

…ommunity/fv3atm into feature/mn_cleanup_202211

Merge remote-tracking branch 'upstream/develop' into feature/mn_clean…

e247e12

…up_202211

Update submodule atmos_cubed_sphere.

8704375

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

89a6485

…mn_cleanup_202211

junwang-noaa reviewed Dec 13, 2022

View reviewed changes

Comment thread CMakeLists.txt Outdated

Remove unneeded empty lines in CMakeLists.txt.

9753c11

junwang-noaa reviewed Dec 13, 2022

View reviewed changes

Comment thread moving_nest/fv_moving_nest.F90 Outdated

wramstrom added 2 commits December 13, 2022 14:34

Updated wording of GNU license

6b3b492

Merge branch 'feature/mn_cleanup_202211' of https://github.com/hafs-c…

9ed5ccb

…ommunity/fv3atm into feature/mn_cleanup_202211

wramstrom approved these changes Dec 13, 2022

View reviewed changes

junwang-noaa approved these changes Dec 13, 2022

View reviewed changes

BinLiu-NOAA added 2 commits December 14, 2022 15:39

Update submodule ccpp/physics and .gitmodules.

5fef3ad

Note: Need to update submodule atmos_cubed_sphere once the PR is merged.

Merge branch 'feature/mn_cleanup_202211' of https://github.com/hafs-c…

f438eff

…ommunity/fv3atm into feature/mn_cleanup_202211

jkbk2004 requested a review from DusanJovic-NOAA December 14, 2022 21:55

DusanJovic-NOAA approved these changes Dec 14, 2022

View reviewed changes

Update submodule atmos_cubed_sphere.

bcb770a

jkbk2004 merged commit 1d97e1f into NOAA-EMC:develop Dec 15, 2022

grantfirl mentioned this pull request Dec 20, 2022

UFS-dev PR#27 NCAR/fv3atm#79

Merged

BinLiu-NOAA deleted the feature/mn_cleanup_202211 branch November 26, 2025 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HAFSv1 related developments and moving-nesting code restructure#610

HAFSv1 related developments and moving-nesting code restructure#610
jkbk2004 merged 47 commits into
NOAA-EMC:developfrom
hafs-community:feature/mn_cleanup_202211

BinLiu-NOAA commented Dec 4, 2022 •

edited

Loading

Uh oh!

wramstrom commented Dec 8, 2022

Uh oh!

DusanJovic-NOAA commented Dec 8, 2022

Uh oh!

Uh oh!

Uh oh!

junwang-noaa commented Dec 13, 2022

Uh oh!

wramstrom commented Dec 13, 2022

Uh oh!

grantfirl commented Dec 14, 2022

Uh oh!

jkbk2004 commented Dec 14, 2022

Uh oh!

jkbk2004 commented Dec 14, 2022

Uh oh!

BinLiu-NOAA commented Dec 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

BinLiu-NOAA commented Dec 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue(s) addressed

Testing

Dependencies

Uh oh!

wramstrom commented Dec 8, 2022

Uh oh!

DusanJovic-NOAA commented Dec 8, 2022

Uh oh!

Uh oh!

Uh oh!

junwang-noaa commented Dec 13, 2022

Uh oh!

wramstrom commented Dec 13, 2022

Uh oh!

grantfirl commented Dec 14, 2022

Uh oh!

jkbk2004 commented Dec 14, 2022

Uh oh!

jkbk2004 commented Dec 14, 2022

Uh oh!

BinLiu-NOAA commented Dec 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

BinLiu-NOAA commented Dec 4, 2022 •

edited

Loading