Correction of convective cloud condensate in prog closure for HR2#639
Merged
Conversation
37 tasks
DusanJovic-NOAA
approved these changes
Apr 4, 2023
Qingfu-Liu
approved these changes
Apr 4, 2023
Collaborator
|
@lisa-bengtsson ufs-community/ccpp-physics#57 was merged. This is ready to revert the changes in .gitmodules (which it looks like you already did) and update the ccpp/physics submodule pointer to the latest commit (after the ccpp-physics PR was merged) in ufs/dev. |
Collaborator
|
@lisa-bengtsson ccpp pr was merged . can you update ccpp submodule pointer? correct hash is ufs-community/ccpp-physics@57c444f |
Collaborator
|
@lisa-bengtsson branch is pointing to ccpp 03acf73 hash. correct one is 57c444f |
jkbk2004
approved these changes
Apr 6, 2023
Contributor
Author
|
@jkbk2004 Now it looks to be correct. Thank you. |
Contributor
Author
|
@jkbk2004 is this merged? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the prognostic closure in samfdeepcnv.f and samfshalcnv.f for HR2: