sync develop#10
Merged
Merged
Conversation
…re for the P8 physics suite) (NOAA-EMC#592) * This is equivalent to PR66 in NCAR/fv3atm: NCAR/main PR NOAA-EMC#66 (Bugfix and optimization of prognostic closure for the P8 physics suite)
…EMC#587) * fixes and workarounds for uninitialized memory in fv_regional_bc * initialize kmaxfire in module_bl_mynn * smoke bug fixes for restart * remove smoke bug fixes * remove workarounds and fix remaining known bugs in ps_reg * a few more surface pressure bug fixes; now the test case runs in debug mode * ccpp/physics: module_sf_ruclsm imprecision workaround for gfortran -DDEBUG=ON * move sanity checks to lsm_ruc and add "snow on ice" check * use i-1 & j-1 for two-point averages, when available * Replace many changes with atmos_cubed_sphere PR NOAA-EMC#220
* update gitmodules and point to PR branch of ccpp/physics * Small cloud tunings from Greg Thompson (NOAA-EMC#580) Co-authored-by: Grant Firl <Grfirl@Grfirl-lt.local>
* fixes for land coupling * work to support external land component side-by-side config * fix issue with ort dbg test
* Add a new SDF named FV3_WoFS_v0 for SRW_v2.1 release * Minor bug fix to add variable nf_albd in the host model data structure (CCPP_typedefs.F90)
* Enable AOD diagnostics when coupled with AQM Co-authored-by: Raffaele Montuoro <raffaele.montuoro@noaa.gov>
…A-EMC#599) * Improve radiative fluxes and cloud cover in ccpp/physics for HR1
… 550nm (NOAA-EMC#597) * Adjust GFS diagnostic ADO output to the exact 550nm in ccpp/physics * Modify a few lines of code in ccpp/physics/physics/radiation_aerosols.f to make them properly indented
* Switch ccpp-physics submodue. * ccpp #17: git action ci yaml update.
* Add convective cloud to radiation, Thompson MP only.
* change fv3atm branch to bugfix/noahmp_hr1 and change ccpp-physics pointer
* Change ccpp-physics branch to fix_tq2m_diagnoahmp
…ototype 8, and turn on prognostic closure (NOAA-EMC#598) * update TKE contribution from cu for progsigma in deep and shallow cu
JiliDong-NOAA
added a commit
that referenced
this pull request
Jun 3, 2025
This PR will restore restart reproducibility of RRFSv1 when using saSAS deep convection and progsigma. The change will add the correct logic when initializing sigmab (the updraft area fraction). Although not being turned on in RRFSv1, saSAS shallow convection is also modified accordingly for consistency. This PR has no impact on warm start runs. Co-authored-by: jili dong <jili.dong@clogin07.cactus.wcoss2.ncep.noaa.gov>
JiliDong-NOAA
added a commit
that referenced
this pull request
Mar 5, 2026
…AA-EMC#1019) * Add 'ebu_smoke' to restart if rrfs_sd is enabled * update ccpp/physics (#10) This PR will restore restart reproducibility of RRFSv1 when using saSAS deep convection and progsigma. The change will add the correct logic when initializing sigmab (the updraft area fraction). Although not being turned on in RRFSv1, saSAS shallow convection is also modified accordingly for consistency. This PR has no impact on warm start runs. * Acsnow restart fix (#11) * fix for snow water equivalent accumulation restart reproducibility * update ccpp/physics * Add write grid comp. restart support for fv_diag.res file * update ccpp/physics * Restart fix (#12) * update ccpp/physics --------- * output sfc spfh to history file * update GFDL_atmos_cubed_sphere * update atmos_cubed_sphere for hailcast * update ccpp/physics to fix C3 compiling error * reverse ccpp-physics and atmos_cubed back to community * update atmos_cubed_sphere and ccpp/physics ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs