Skip to content

feat(api): drive scientific acceptance via loopback CLI - #362

Closed
seonghobae wants to merge 2 commits into
feat/scientific-acceptance-http-lifecycle-gap-003afrom
feat/scientific-acceptance-loopback-cli-gap-003a
Closed

feat(api): drive scientific acceptance via loopback CLI#362
seonghobae wants to merge 2 commits into
feat/scientific-acceptance-http-lifecycle-gap-003afrom
feat/scientific-acceptance-loopback-cli-gap-003a

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Consolidation decision — closed with the retired scientific-acceptance wire

This PR is not merged. Its exact head d8f3c5faf6aee5791e5752b4d0d02a0726391d26 is preserved as CLI/fail-closed lineage, but the CLI's defining succeeded-state behavior prints tepp.scientific_acceptance.v1 from the now-retired #356/#358 authority chain.

Fold the reusable CLI mechanics into the coherent Analysis Run application/adapter landing vehicle under #166/#435: loopback-only transport, credential refusal, typed create/lifecycle/status framing, metric-free accepted/running output, reverse-transition refusal, and current-head CLI tests. Do not preserve a CLI verb whose success contract itself asserts the invalid scientific-acceptance artifact.

A future CLI may expose versioned Validation Evidence produced by the owning Rust validation path, but Scientific Claim Promotion remains a separate policy/aggregate and cannot be inferred from command success. Branch, tests, review history and doctoring remain available for evidence-preserving fold.

GAP-003A fifth slice for issue #166. tepp-analysis-run creates, records
running/terminal, and reads status on the loopback listener. Accepted and
running stay metric-free; tepp.scientific_acceptance.v1 prints only on a
succeeded scientific_acceptance_v1 status. Non-loopback hosts, credential
flags, and failed-plus-artifact emission fail closed. ADR 0029.
Live #361 already owns ADR 0029 for loopback cancel HTTP. Keep CLI
authority on a distinct number so the stacked GAP-003A client does not
collide.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Hour-20 exact-head review request.

Current head d8f3c5faf6aee5791e5752b4d0d02a0726391d26. Devin/CodeRabbit/author COMMENTED is not independent APPROVE. OpenCode DISMISSED/REQUEST_CHANGES on predecessor heads does not transfer. Ruleset 18156473 needs two independent APPROVE reviews on this exact SHA.

GAP-003A loopback scientific-acceptance CLI draft stacked on #360. ADR 0030. Do not duplicate this CLI. Do not open another tepp-analysis-run PR.

Do not self-approve. Do not --admin merge. Checks/reviews are not a reason to weaken fail-closed gates.

Copy link
Copy Markdown
Contributor Author

Hour-21 exact-head review request.

Current head d8f3c5faf6aee5791e5752b4d0d02a0726391d26.
Devin/CodeRabbit/author COMMENTED is not independent APPROVE. Copilot review requests are not APPROVE. Ruleset 18156473 needs two independent approvals. Do not self-approve. Do not merge without two independent APPROVE reviews on this exact head.

@opencode-agent review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant