feat(analysis): bind TDT/CHRONOS composition to an analysis-run profile - #364
feat(analysis): bind TDT/CHRONOS composition to an analysis-run profile#364seonghobae wants to merge 2 commits into
Conversation
Operators can request the existing event_core workflow as tdt_chronos_workflow_v1. Mentions unavailable at the request cutoff are excluded; the digest-bound tepp.tdt_chronos_workflow.v1 artifact records detection versus prediction layers and refuses instance/transition promotion. Not a new extractor, not persistence, and not implemented-main.
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Exact-head coverage remains pending
Repository rules require 100% production line and branch coverage. The PR description leaves exact-head checks pending for the new validation and error paths.
Was this helpful? React with 👍 or 👎 to provide feedback.
| config: input.config, | ||
| segmentation: input.segmentation, | ||
| mentions, | ||
| links, | ||
| first_story_labels, | ||
| track_assignments, | ||
| schema_slot_assignments: input.schema_slot_assignments, | ||
| occurrence_forecasts: input.occurrence_forecasts, |
There was a problem hiding this comment.
🔴 Late workflow evidence survives cutoff
When a run uses an earlier cutoff, admit_mentions_at_cutoff filters mentions but retains segmentation, schema slots, and forecasts unchanged. Results can include future-derived evidence.
Was this helpful? React with 👍 or 👎 to provide feedback.
| let links: Vec<_> = input | ||
| .links | ||
| .into_iter() | ||
| .filter(|link| eligible_ids.contains(&link.left()) && eligible_ids.contains(&link.right())) | ||
| .collect(); |
There was a problem hiding this comment.
🟡 Foreign links are silently accepted
When a link references a mention absent from the input, filter drops it as cutoff-excluded. Malformed workflows can succeed with understated links.
Was this helpful? React with 👍 or 👎 to provide feedback.
| run_id: accepted.run_id.clone(), | ||
| snapshot_id: snapshot_id.to_owned(), | ||
| knowledge_cutoff: knowledge_cutoff.to_rfc3339(), | ||
| workflow_version: composition.config_version(), |
There was a problem hiding this comment.
🟡 Workflow configuration escapes the digest
Replaying one accepted run with changed thresholds makes from_composition record only version 1. Different decision configurations can produce indistinguishable artifacts and digests.
Was this helpful? React with 👍 or 👎 to provide feedback.
| pub fn to_json(&self) -> Result<String, AnalysisEngineError> { | ||
| self.validate()?; | ||
| let payload = | ||
| serde_json::to_string(self).map_err(|_| AnalysisEngineError::SerializationFailure)?; | ||
| Ok(payload) | ||
| } |
There was a problem hiding this comment.
🔍 Output limit is one-sided
to_json omits the advertised 256 KiB check. Current bounded fields stay small, but future variable-sized schema fields can bypass the output contract.
Was this helpful? React with 👍 or 👎 to provide feedback.
| let _ = refuse_composition_as_instance(&composition); | ||
| let _ = refuse_composition_as_transition(&composition); |
There was a problem hiding this comment.
📝 Info: Refusal calls are declarative
Both refusal APIs always return fixed errors without side effects. Ignoring their results preserves the boundary, but the calls add no runtime validation.
Was this helpful? React with 👍 or 👎 to provide feedback.
| if input.first_story_labels.len() != input.mentions.len() | ||
| || input.track_assignments.len() != input.mentions.len() | ||
| { | ||
| return Err(AnalysisEngineError::Event(EventError::InvalidWirePayload)); | ||
| } | ||
| let mut mentions = Vec::new(); | ||
| let mut first_story_labels = Vec::new(); | ||
| let mut track_assignments = Vec::new(); | ||
| let mut excluded_after_cutoff_count = 0_u64; | ||
| for ((mention, first_story), track) in input | ||
| .mentions | ||
| .into_iter() | ||
| .zip(input.first_story_labels) | ||
| .zip(input.track_assignments) | ||
| { | ||
| if mention.clocks().available_time().instant() <= knowledge_cutoff.instant() { | ||
| mentions.push(mention); | ||
| first_story_labels.push(first_story); | ||
| track_assignments.push(track); |
There was a problem hiding this comment.
📝 Info: Indexed streams remain aligned
admit_mentions_at_cutoff checks equal lengths before zipping. Each excluded mention removes its corresponding label and track, then composition verifies track identities.
Was this helpful? React with 👍 or 👎 to provide feedback.
| let admitted = admit_mentions_at_cutoff(input, knowledge_cutoff)?; | ||
| let composition = compose_event_intelligence( |
There was a problem hiding this comment.
🟨 Untrusted workflow inputs lack resource bounds
execute_event_intelligence_run accepts unlimited collections before quadratic composition checks. An oversized request can exhaust service CPU and memory.
Was this helpful? React with 👍 or 👎 to provide feedback.
| let summary = AnalysisResultSummary::new( | ||
| "tdt_chronos_workflow", | ||
| artifact.mention_count, | ||
| statistic_count, | ||
| EVENT_INTELLIGENCE_INFERENCE_STATUS, | ||
| ) | ||
| .expect("bounded event-intelligence summary constants are valid"); |
There was a problem hiding this comment.
🔴 Oversized runs panic during completion
Over one billion evidence items or combined outputs makes AnalysisResultSummary::new fail. expect then crashes the executor instead of rejecting the run.
| let summary = AnalysisResultSummary::new( | |
| "tdt_chronos_workflow", | |
| artifact.mention_count, | |
| statistic_count, | |
| EVENT_INTELLIGENCE_INFERENCE_STATUS, | |
| ) | |
| .expect("bounded event-intelligence summary constants are valid"); | |
| let summary = AnalysisResultSummary::new( | |
| "tdt_chronos_workflow", | |
| artifact.mention_count, | |
| statistic_count, | |
| EVENT_INTELLIGENCE_INFERENCE_STATUS, | |
| )?; |
Was this helpful? React with 👍 or 👎 to provide feedback.
| let links: Vec<_> = input | ||
| .links | ||
| .into_iter() | ||
| .filter(|link| eligible_ids.contains(&link.left()) & eligible_ids.contains(&link.right())) |
There was a problem hiding this comment.
📝 Info: Link filtering remains equivalent
Bitwise & evaluates both pure contains calls, but returns the same Boolean result as &&. No links change eligibility.
Was this helpful? React with 👍 or 👎 to provide feedback.
| ) | ||
| .expect("validated composition produces a valid bounded artifact"); |
There was a problem hiding this comment.
📝 Info: Artifact assertion remains unreachable
Successful composition guarantees every validation invariant used by from_composition. Its length conversions also fit u64 on supported platforms.
Was this helpful? React with 👍 or 👎 to provide feedback.
| #[test] | ||
| fn execution_refuses_invalid_completion_time() { | ||
| let fixture = KnownTruthFixture::build(); | ||
| let request = request(); | ||
| let accepted = accepted(&request); | ||
| assert_eq!( | ||
| execute_event_intelligence_run( | ||
| &request, | ||
| &accepted, | ||
| "snapshot-event-intelligence", | ||
| cutoff(), | ||
| fixture.input(), | ||
| "invalid", | ||
| ), | ||
| Err(AnalysisEngineError::Api( | ||
| tepp_api::ApiError::InvalidWirePayload | ||
| )) | ||
| ); |
There was a problem hiding this comment.
📝 Info: Completion errors still propagate
An invalid completion timestamp reaches terminal-result validation and returns its contract error. The earlier assertions do not mask this failure.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
GAP-007 remaining operator-visible slice: bind the already-merged
event_coreTDT/CHRONOS composition (compose_event_intelligence, #269 on protected main) to ananalysis_engineanalysis-run output profile so operators can request the composed workflow.tdt_chronos_workflow_v1/ schematepp.tdt_chronos_workflow.v1(ADR 0030; 0026–0029 remain on other live PRs).available_timeagainst the requestknowledge_cutoff; drops links that cite an excluded mention; keeps first-story/track streams aligned.tdt_detection; CHRONOS hypotheses staychronos_prediction. Inference status iscomposed_workflow_not_instance_or_transition.refuse_composition_as_instanceandrefuse_composition_as_transition. Does not invent an extractor, persist rows, or promote an instance/transition.This is not implemented-main. Exact-head Checks on this head only. Predecessor-head evidence does not transfer.
Does not duplicate:
Test plan
cargo test -p analysis_enginecargo clippy -p analysis_engine --all-targets -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc -p analysis_engine --no-depsMerge bar
Ruleset 18156473: two independent approvals + exact-head Checks. Do not self-approve. Do not
--adminmerge.