feat(api): inspect analysis-run retry parent on loopback - #384
Draft
seonghobae wants to merge 1 commit into
Draft
Conversation
GAP-003A operator-visible parent GET. Retry-lineage lists children of a
parent; collection does not leak retried_from; idempotency lookup returns
a run_id without linkage. GET /v1/analysis-runs/{run_id}/parent returns
the metric-free parent identity, or null when the run was never retried.
ADR 0038. Stacked on idempotency-key lookup GET (#380).
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GAP-003A operator-visible retry-parent GET on the loopback analysis-run surface.
GET /v1/analysis-runs/{run_id}/parentreturns the metric-free parent identity of a listed run. Retry-lineage GET (#379) lists children of a parent. Collection GET (#368) does not leakretried_from. Idempotency-key lookup GET (#380) resolves a key to arun_idwithout linkage. Operators looking at a retry child cannot see which parent it came from.Stacked on #380 (
ed21a105) over retry-lineage #379 over stored-request #377 over retry #369 over collection #368 over cancel #361 over protectedmain.Issue: #166
Contract
run_id/run_state/idempotency_key/parent({run_id, run_state, idempotency_key}or JSONnull). Theparentkey is always present."parent": null.LiveAnalysisRun.retried_from_run_id.rmse,bias,coverage, SE-gate,scientific_acceptance,report,terminal_result,tenant_workspace_id. Response JSON also refusessnapshot_id/retried_fromleak./cancel,/retry,/retries,/request,/running,/terminal,/by-idempotency.retried_from. Retry-lineage GET remains 200. Stored-request GET remains 200. Idempotency lookup remains 200.ADR
This slice uses ADR 0038 (
docs/adr/0038-analysis-run-retry-parent-get.md).Do not reuse 0030 (#362/#364/#373), 0031 (#368), 0032 (#369/#370/#371), 0033 (#372/#375/#378), 0034 (#374/#377/#381), 0035 (#379), 0036 (#376), or 0037 (#380/#382). Next free ADR is 0039.
Not this PR (live — do not duplicate)
df33bfa3)96a34a41)42e05e31)99464037)dba3db0e)d8f3c5fa)b7a039b8)6a5d9777)58bfc40d)3f9e2d8b)f7d5e5a3)cc8ed995)837a18ab)442b159d)409a7bdc)58bacd75)f80bd97c)c891d46a)2040a763)ed21a105) — this PR's baseb9aff1e0)bf45147f)Verification (local)
cargo clippy -p tepp_api --all-targets -- -D warningscargo test -p tepp_api --all-targets(97 lib tests including retry-parent GET)RUSTDOCFLAGS='-D warnings' cargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.pyHead:
c12ea6005c808fad36e782f5d175f7d85a28170eDo not self-approve. Do not
--adminmerge. Ruleset 18156473 requires two independent current-head APPROVE reviews. Copilot/Devin/CodeRabbit COMMENTED is not independent APPROVE.