feat(analysis): serve scientific acceptance execute from tepp-loopback - #375
Closed
seonghobae wants to merge 1 commit into
Conversation
Move the published tepp-loopback binary onto ScientificAcceptanceLoopbackService
so POST /v1/analysis-runs/{run_id}/execute is reachable without embedding the
library. tepp_api no longer ships that binary (crate cycle). ADR 0033.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidation decision — closed with invalid #370 execution authority
This PR is not merged. Exact head
409a7bdc8a85ef8981aaaf076f1dba7e9f151858exists solely to package the #370 scientific-acceptance executor intotepp-loopback; #370 is now closed because it directly depends on the retired #356 scientific authority.Preserve the useful deployment evidence for #166: binary ownership, Docker build path, loopback bind behavior, bounded temporal-context health checks and crate-cycle lessons. Rebuild/fold those pieces only after the corrected Validation Evidence executor exists. A packaged binary must not make an invalid scientific-acceptance aggregate authoritative.
Branch, tests and review history remain available as implementation lineage; do not reopen this stack without replacing the underlying executor contract.