feat(api): retry failed and cancelled analysis runs on loopback - #369
Draft
seonghobae wants to merge 1 commit into
Draft
feat(api): retry failed and cancelled analysis runs on loopback#369seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
GAP-003A eighth slice: POST /v1/analysis-runs/{run_id}/retry clones a
failed or cancelled run into a new metric-free 202 Accepted with a new
idempotency key. Accepted, running, succeeded, and unknown runs fail
closed. Stacked on collection GET. ADR 0032.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 31, 2026
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GAP-003A still has no operator-visible retry path.
docs/API_CONTRACT.mddocumentsfailed → retryable, and collection GET (#368) can list a failed or cancelled run, butPOST /v1/analysis-runswith the original idempotency key returns the original receipt. Operators cannot start a new attempt without reconstructing the original body.Live slices that this PR does not duplicate:
analysis_enginescientific-acceptance library6a5d9777e2cf76c48726ae0243da872993d8881d)What
Eighth GAP-003A slice stacked on #368 over protected main
1bc02f580cf48e1d39da239f0e818453437c31c3:POST /v1/analysis-runs/{run_id}/retryonAnalysisRunLiveService202 Acceptedwith a newrun_idand new idempotency keyrun_id+ header new key)400on this stackNot an ADR 0014 scientific claim. Not persistence. Not GET-by-id. Not lifecycle POST. Not cancel HTTP. Not collection GET. Not loopback CLI.
Verification
cargo clippy -p tepp_api --all-targets -- -D warningscargo test -p tepp_api --all-targetsRUSTDOCFLAGS='-D warnings' cargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.pycrates/tepp_api/tests/analysis_run_retry_http_contract.rsdocs/research/analysis-run-retry-http.mdExact-head Checks on this SHA are required before merge. Two independent current-head APPROVEs are required. Author cannot self-approve. Merge #368 before this stacked PR, or retarget onto protected main after #368 lands. No force-push. Do not self-approve. Do not
--adminmerge.