feat(api): create hypothetical interpretation runs via loopback CLI - #425
feat(api): create hypothetical interpretation runs via loopback CLI#425seonghobae wants to merge 1 commit into
Conversation
GAP-003A unique slice: tepp-interpretation-runs create mints typed contextual-orchestrator POST /v1/interpretation-runs onto spawned tepp-orchestrator-loopback TCP. Metric-free hypothetical JSON only. Naruon and LineageWeave are refused. Persistence remains GAP-003B. ADR 0064 unique vs main.
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Coverage evidence is missing
The repository requires 100% production line and branch coverage. The submitted verification omits that gate despite substantial new production branching.
Was this helpful? React with 👍 or 👎 to provide feedback.
| .unwrap_or(usize::MAX); | ||
| let mut service = OrchestratorLiveService::bind(bind_addr)?; | ||
| println!("{}", service.local_addr()?); | ||
| (0..request_limit).for_each(|_| drop(service.serve_one())); |
There was a problem hiding this comment.
🟡 Listener failures report success
drop discards every serve_one failure. A bounded listener can consume its quota and exit successfully without serving the configured requests.
| (0..request_limit).for_each(|_| drop(service.serve_one())); | |
| for _ in 0..request_limit { | |
| service.serve_one()?; | |
| } |
Was this helpful? React with 👍 or 👎 to provide feedback.
| fn compose_https_target(origin: &str, path: &str) -> Result<String, OrchestratorLiveError> { | ||
| require_nonempty(origin)?; | ||
| if !origin.starts_with("https://") || origin.ends_with('/') { | ||
| return Err(OrchestratorLiveError::InvalidWirePayload); | ||
| } | ||
| let rest = origin | ||
| .strip_prefix("https://") | ||
| .ok_or(OrchestratorLiveError::InvalidWirePayload)?; | ||
| if rest.contains('@') || rest.contains('?') || rest.contains('#') || rest.contains('\\') { | ||
| return Err(OrchestratorLiveError::InvalidWirePayload); | ||
| } | ||
| if host_implies_table_access(rest) { | ||
| return Err(OrchestratorLiveError::InvalidWirePayload); | ||
| } | ||
| Ok(format!("{origin}{path}")) |
There was a problem hiding this comment.
🔍 Origin contract accepts path segments
compose_https_target accepts empty authorities and embedded path segments. Public callers can receive target URLs that violate the established host-only origin convention.
Was this helpful? React with 👍 or 👎 to provide feedback.
| .unwrap_or(usize::MAX); | ||
| let mut service = OrchestratorLiveService::bind(bind_addr)?; | ||
| println!("{}", service.local_addr()?); | ||
| (0..request_limit).for_each(|_| drop(service.serve_one())); |
There was a problem hiding this comment.
🟨 Idle clients can halt the listener
A same-host process can hold one connection open without sending a request. The single-threaded listener blocks indefinitely and serves no later clients.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Folded into #436
Closed as
superseded_by_fold, not discarded. #436's current head contains this PR as an ancestor and is now based on protectedmain, preserving the interpretation-run create CLI, collection GET/CLI implementation/tests, and this review history while reducing queue WIP. Retrieval vehicles #439/#454 also retain this ancestry.Canonical interpretation-run adapter vehicle: #436 (
feat(api): consolidate interpretation-run create and collection adapters).Do not reopen unless a surviving folded head demonstrably loses unique behavior or evidence.