Skip to content

Updated swagger docs in stable and track1\preview with changes to ImageAnalysis skill#8318

Closed
jennifermarsman wants to merge 36 commits intoAzure:masterfrom
jennifermarsman:master
Closed

Updated swagger docs in stable and track1\preview with changes to ImageAnalysis skill#8318
jennifermarsman wants to merge 36 commits intoAzure:masterfrom
jennifermarsman:master

Conversation

@jennifermarsman
Copy link
Contributor

@jennifermarsman jennifermarsman commented Feb 6, 2020

Updated swagger docs in stable and track1\preview with changes to ImageAnalysis skill (new languages and visual features)

This is just a swagger change that did not change the SDK, as per Bruce's instructions. Data plane API.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

…geAnalysis skill (new languages and visual features)
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Daniel Stack and others added 11 commits February 6, 2020 12:01
…iew/2020-02-01-preview (#8287)

* Adds base for updating Microsoft.Maps from version stable/2018-05-01 to version 2020-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* add private atlas resource and examples

* fixing invalid format

* fixing build validation errors

* fixing style

* removing 202 from review feedback

* api version, inheritance, and feedback

* removing 404 from examples and fixing version

* fixing readme and remaining 404s

* fixing typo

* trying to fix missing input file

* fixing output directory

* adding tags to support docs preview

* fixing List Operations name and sample

* adding supressions and fix for operations

* fixing the schema

* removing isDataAction to fix

* supress nested tracked, and remove move
…d to AzureMonitor on different PR) (#8311)

* remove from app insights

* remove from app insights

* Revert "remove from app insights"

This reverts commit 2d9eb76.

* Revert "remove from app insights"

This reverts commit 138ace2.

* remove properly
… ApplicationInsights) (#8310)

* privatelinkscope api

* Update readme.md
* Document stable ATP settings API

* Update Readme.md and add examples

* Fix readme.md

* force another build
* Add PGSQL to AzurePGSQL swagger changes

* Add trust and encrypt connections flags to the PG scenario

* Renamed postgree to postgres and configured and changed text

* Adding custom words

* Resolving discriminator issues

* Fixing typo

* Renamed 'ResultType' to 'resultType'

* Made result task not read only

* prettier run
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* added allowed NoContent response for deleting key vaults

* fixed 204 response description

* added 204 to deleteVault examples

* fixed old problems in 2016-10-01 examples
@brjohnstmsft
Copy link
Member

@lmazuel I'm assuming you're the designated Swagger reviewer for this PR. Please be aware that no client libraries have been shipped yet that depend on this spec (shipped libraries depend on specs in the "track1" folder), so breaking changes are not a concern here.

Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifermarsman The changes look fine to me (not being a skillset SME), but I know @arv100kri had some opinions on whether the various enums used in skills should be extensible or not.

LijuanZ and others added 9 commits February 8, 2020 09:15
…m domain (#8299)

* Add new parameter for minimum TLS version

* Add new parameter for minimum TLS version

* Making the parameter casing consistent

* Making parameter name case consistent
* Adding new fields to transactions API

Adding new fields to transactions API

* Updated the field description

Updated the field description

* Updated few descriptions

* [BillingRP] New API to list transactions by invoice

[BillingRP] New API to list transactions by invoice

* Incorporating review comments

Incorporating review comments

* Updated description

* Updated transaction description

* Updated description

* Added unbilled to custom words
* Fix SDK Automation auto cancel issue

* Disable autoCancel in all pipeline
* Swagger changes for adding a new API version in Backup

* Adding 2 list APIs specific to the new version

* Resolving comments and fixing spell check errors

* Fixing test errors

* Fixing lint diff errors

* Fixing lint diff errors

* Fixing AAD properties API

* Fixing semantic error and removing HTTP 400 code

* Removing error code from example as well

* Removing default keyword as it is not supported by our RP

* Removing 2019-05-13 version from existing package

* Resolving comments

* Resolving comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow it looks like you've added commits from master to your PR that aren't just merge commits. Please recreate your PR from a topic branch (i.e. -- not jennifermarsman:master) after applying your changes on top of Azure:master.

@jennifermarsman
Copy link
Contributor Author

Closing this pull request and opening new one for this change: #8371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.