Updated swagger doc in stable with changes to ImageAnalysis skill#8371
Conversation
…w languages and visual features)
jennifermarsman
requested review from
arv100kri,
bleroy and
brjohnstmsft
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Also note that changes were made only in the "stable" version. Will this automatically be added into the next preview as well? (Currently there is a preview in track1 only, and I didn't make changes there, and I'm not sure if the preview-2019-05-06 will be created from https://github.com/Azure/azure-rest-api-specs/tree/master/specification/search/data-plane/Microsoft.Azure.Search.Service/stable/2019-05-06/ OR https://github.com/Azure/azure-rest-api-specs/tree/master/specification/search/data-plane/Microsoft.Azure.Search.Service/track1/preview/2019-05-06-preview.) @brjohnstmsft: does this concern make sense? Are you the one who will be doing this? Also added @Careyjmac for review, as she did the code and doc changes for this. |
|
@jennifermarsman I'll be creating the new Track 2 spec for 2019-05-06-preview by combining the result of this PR with the changes in the Track 1 preview spec, with your team's help if necessary. |
brjohnstmsft
left a comment
brjohnstmsft
left a comment
There was a problem hiding this comment.
LGTM, but more SMEs should look at this
|
FYI @jhendrixMSFT -- This review got auto-assigned to @sarangan12, but I don't think he's around. Would you be able to review our Swagger changes (we'll have a lot more coming soon)? If not, do you know who the right person would be? |
|
Changes look good, are we waiting for other reviews or is this ready to merge? |
|
@jhendrixMSFT Ready to merge, thanks! |
…w languages and visual features) (Azure#8371)
…w languages and visual features) (Azure#8371)
5 participants
Updated swagger doc in stable with changes to ImageAnalysis skill (new languages and visual features).
I tested for local validation using the following commands, and both returned no errors:
autorest --azure-validator --input-file=searchservice.json --message-format=json --openapi-type=data-plane
oav validate-spec searchservice.json
I tried to test on the OpenAPI Hub. The static validation passed, but the linter hung indefinitely when processing. (How long is this supposed to take?)
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.