Skip to content

HanaOnAzure: Update Swagger with SKUs for SD-Flex#8326

Merged
ArcturusZhang merged 1 commit intoAzure:masterfrom
lagalbra:lagalbra/add-sdflex-skus
Feb 11, 2020
Merged

HanaOnAzure: Update Swagger with SKUs for SD-Flex#8326
ArcturusZhang merged 1 commit intoAzure:masterfrom
lagalbra:lagalbra/add-sdflex-skus

Conversation

@lagalbra
Copy link
Contributor

@lagalbra lagalbra commented Feb 6, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lagalbra
Copy link
Contributor Author

lagalbra commented Feb 6, 2020

Re-opening since validation was cancelled on #8315

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Feb 7, 2020

Re-opening since validation was cancelled on #8315

There is a command /azp run that can retrigger the CIs. Let me show you. But the automation-sdk CI will require some kind of permission to run.

@ArcturusZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 7, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 7, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 7, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 8c8e4b7 with merge commit a4bc312. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-hanaonazure [Logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/hanaManagementClient.js → ./dist/arm-hanaonazure.js...
    [npmPack] created ./dist/arm-hanaonazure.js in 258ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 7, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 7, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

Copy link
Contributor

@pabowers pabowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArcturusZhang ArcturusZhang merged commit a4bc312 into Azure:master Feb 11, 2020
ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@lagalbra lagalbra deleted the lagalbra/add-sdflex-skus branch July 14, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants