Microsoft.insights Remove PrivateLinkScope API from AppInsights (moved to AzureMonitor on different PR) by arolshan · Pull Request #8311 · Azure/azure-rest-api-specs

arolshan · 2020-02-05T16:52:28Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-05T16:52:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T16:52:51Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T16:52:51Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T16:52:54Z

Azure Pipelines successfully started running 1 pipeline(s).

arolshan · 2020-02-05T16:54:15Z

These change were introduced in a PR today #8311

This API is just moved to a different folder- same provider. It was put in applicationinsights by mistake.

Put in the right folder in this PR - #8310.

openapi-sdkautomation · 2020-02-05T16:54:18Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6609b7e with merge commit 8552a31. SDK Automation 13.0.17.20191226.1
️✔️sdk/applicationinsights/mgmt-v2015_05_01 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-02-05T16:54:20Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6609b7e with merge commit 8552a31. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-appinsights [Logs] [Release SDK Changes]

azure-arm-appinsights-2.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
[npmPack] created ./dist/arm-appinsights.js in 434ms

openapi-sdkautomation · 2020-02-05T16:54:20Z

azure-sdk-for-js

❌ failed [Logs] [Expand Details]

❌ Generate from 2d9eb76 with merge commit 4677ae6121b426d266f08ded97a5c386adefb311. SDK Automation 13.0.17.20191226.1

❌@azure/arm-appinsights [Logs] [Preview SDK Changes]

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm ERR! Unexpected end of JSON input while parsing near '...","minimist":"latest"'
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/vsts_azpcontainer/.npm/_logs/2020-02-05T16_55_09_056Z-debug.log
[npmPack] npm ERR! code ELIFECYCLE
[npmPack] npm ERR! errno 1
[npmPack] npm ERR! @azure/arm-appinsights@2.1.0 prepack: `npm install && npm run build`
[npmPack] npm ERR! Exit status 1
[npmPack] npm ERR! 
[npmPack] npm ERR! Failed at the @azure/arm-appinsights@2.1.0 prepack script.
[npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[npmPack] npm WARN Local package.json exists, but node_modules missing, did you mean to install?
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/vsts_azpcontainer/.npm/_logs/2020-02-05T16_55_09_077Z-debug.log
Failed to create the package @azure/arm-appinsights.
Error: npm pack --loglevel warn npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
npm ERR! Unexpected end of JSON input while parsing near '...","minimist":"latest"'
npm ERR! A complete log of this run can be found in:

npm ERR!     /home/vsts_azpcontainer/.npm/_logs/2020-02-05T16_55_09_056Z-debug.log

npm ERR! code ELIFECYCLE

npm ERR! errno 1

npm ERR! @azure/arm-appinsights@2.1.0 prepack: npm install && npm run build

npm ERR! Exit status 1

npm ERR!

npm ERR! Failed at the @azure/arm-appinsights@2.1.0 prepack script.

npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! A complete log of this run can be found in:

npm ERR!     /home/vsts_azpcontainer/.npm/_logs/2020-02-05T16_55_09_077Z-debug.log

, {}

openapi-sdkautomation · 2020-02-05T16:54:21Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6609b7e with merge commit 8552a31. SDK Automation 13.0.17.20191226.1
⚠️appinsights/mgmt/2015-05-01 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-02-05T16:54:23Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6609b7e with merge commit 8552a31. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-applicationinsights [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2020-02-05T16:54:24Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6609b7e with merge commit 8552a31. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.ApplicationInsights [Logs] [Release SDK Changes]
No Artifact Generated.

This reverts commit 2d9eb76.

This reverts commit 138ace2.

azure-pipelines · 2020-02-05T17:00:48Z

Azure Pipelines successfully started running 1 pipeline(s).

allenjzhang · 2020-02-05T17:13:49Z

/azp run

azure-pipelines · 2020-02-05T17:14:10Z

Azure Pipelines successfully started running 3 pipeline(s).

pilor · 2020-02-05T18:04:08Z

Nothing to review from the ARM side

weidongxu-microsoft · 2020-02-06T01:56:12Z

@arolshan
Let me know when you are ready to merge.

arolshan · 2020-02-06T05:49:26Z

@arolshan
Let me know when you are ready to merge.

please merge.
And can u merge the other PR as well?
#8310

Thanks

…d to AzureMonitor on different PR) (Azure#8311) * remove from app insights * remove from app insights * Revert "remove from app insights" This reverts commit 2d9eb76. * Revert "remove from app insights" This reverts commit 138ace2. * remove properly

arolshan added 2 commits February 5, 2020 18:48

remove from app insights

138ace2

remove from app insights

2d9eb76

openapi-assignment-bot bot assigned weidongxu-microsoft Feb 5, 2020

arolshan mentioned this pull request Feb 5, 2020

Microsoft.insights PrivateLinkScope API for Azure Monitor (Moved from ApplicationInsights) #8310

Merged

5 tasks

arolshan assigned pilor Feb 5, 2020

arolshan added 3 commits February 5, 2020 18:59

Revert "remove from app insights"

13de5d3

This reverts commit 2d9eb76.

Revert "remove from app insights"

0b1610e

This reverts commit 138ace2.

remove properly

6609b7e

pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 5, 2020

weidongxu-microsoft approved these changes Feb 6, 2020

View reviewed changes

arolshan requested a review from weidongxu-microsoft February 6, 2020 05:49

akning-ms merged commit 8552a31 into Azure:master Feb 6, 2020

Conversation

arolshan commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

arolshan commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

allenjzhang commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

pilor commented Feb 5, 2020

Uh oh!

weidongxu-microsoft commented Feb 6, 2020

Uh oh!

arolshan commented Feb 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arolshan commented Feb 5, 2020 •

edited

Loading

arolshan commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading