Add trigger evalation API to swagger by calecarter · Pull Request #8312 · Azure/azure-rest-api-specs

calecarter · 2020-02-05T18:33:39Z

Latest improvements:

Added missing triggerEvaluation API to PolicyInsights swagger

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-05T18:33:57Z

Azure Pipelines successfully started running 1 pipeline(s).

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json

azure-pipelines · 2020-02-05T19:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T19:37:58Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T19:44:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T19:50:56Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T19:56:47Z

Azure Pipelines successfully started running 1 pipeline(s).

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json

pilor · 2020-02-05T20:44:11Z

/azp run automation - sdk

azure-pipelines · 2020-02-05T20:44:22Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-05T20:45:37Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1
⚠️policyinsights/mgmt/2018-04-04 [Logs]
```
No file is changed.
```
️✔️policyinsights/mgmt/2019-10-01 [Logs] [Release SDK Changes]
- policyinsights.mgmt.2019-10-01.zip
⚠️preview/policyinsights/mgmt/2018-07-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-02-05T20:45:38Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1
️✔️sdk/policyinsights/mgmt-v2018_04_04 [Logs] [Release SDK Changes]

⚠️sdk/policyinsights/mgmt-v2018_07_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:94: error: '{' expected
[mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
[mvn] [ERROR]                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error: = expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                             ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error:  expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                                           ^
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

⚠️sdk/policyinsights/mgmt-v2019_10_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:99: error: '{' expected
[mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
[mvn] [ERROR]                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error: = expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                             ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error:  expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                                           ^
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

openapi-sdkautomation · 2020-02-05T20:45:38Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.PolicyInsights [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.PolicyInsights.3.0.0.nupkg
- Microsoft.Azure.Management.PolicyInsights.3.0.0.snupkg

openapi-sdkautomation · 2020-02-05T20:45:46Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-policyinsights [Logs] [Release SDK Changes]

azure-arm-policyinsights-3.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/policyInsightsClient.js → ./dist/arm-policyinsights.js...
[npmPack] created ./dist/arm-policyinsights.js in 482ms

openapi-sdkautomation · 2020-02-05T20:45:49Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-policyinsights [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

sandipsh

pilor · 2020-02-05T21:56:47Z

@myronfanqiu ready for you

mmyyrroonn · 2020-02-06T08:23:36Z

@pilor @calecarter Good work. Merged it. Thanks!

Add trigger evalation API to swagger

d48e850

openapi-assignment-bot bot assigned mmyyrroonn Feb 5, 2020

calecarter requested review from cemheren, pilor and sandipsh February 5, 2020 18:34

pilor reviewed Feb 5, 2020

View reviewed changes

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json Outdated Show resolved Hide resolved

pilor reviewed Feb 5, 2020

View reviewed changes

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json Show resolved Hide resolved

pilor reviewed Feb 5, 2020

View reviewed changes

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json Outdated Show resolved Hide resolved

pilor reviewed Feb 5, 2020

View reviewed changes

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json Outdated Show resolved Hide resolved

pilor reviewed Feb 5, 2020

View reviewed changes

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json Outdated Show resolved Hide resolved

pilor added ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 5, 2020

Updated based on feedback

14ea14b

Fixed typos based on feedback

5c579ff

Updated examples to include responses defined.

f1e7ca9

Removed body from examples as there isn't one returned.

85ca09a

made prettier

b7bd004

sandipsh reviewed Feb 5, 2020

View reviewed changes

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json Show resolved Hide resolved

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 5, 2020

pilor approved these changes Feb 5, 2020

View reviewed changes

sandipsh approved these changes Feb 5, 2020

View reviewed changes

mmyyrroonn approved these changes Feb 6, 2020

View reviewed changes

mmyyrroonn merged commit 97f9215 into Azure:master Feb 6, 2020

sandipsh mentioned this pull request Feb 19, 2020

az policy state - Trigger policy evaluation through CLI Azure/azure-cli#8016

Closed

ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020

Add trigger evalation API to swagger (Azure#8312)

8790955

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add trigger evalation API to swagger (Azure#8312)

fdfa4b6

Conversation

calecarter commented Feb 5, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

Uh oh!

pilor commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

sandipsh left a comment

Choose a reason for hiding this comment

Uh oh!

pilor commented Feb 5, 2020

Uh oh!

mmyyrroonn commented Feb 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 5, 2020 •

edited

Loading