[DataFactory] modify apis for rerunTrigger#6903
Merged
yungezz merged 26 commits intoAzure:masterfrom Feb 10, 2020
Merged
Conversation
Automation for azure-sdk-for-pythonEncountered an unknown error: (azure-sdk-for-python)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
return next(self.gen)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
repo.git.checkout(branch_or_commit)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git checkout 17c09613fbe29fdd9e00810d07bdea841fc3a756
stderr: 'fatal: reference is not a tree: 17c09613fbe29fdd9e00810d07bdea841fc3a756' |
Automation for azure-sdk-for-goEncountered an unknown error: (azure-sdk-for-go)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
return next(self.gen)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
repo.git.checkout(branch_or_commit)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git checkout 17c09613fbe29fdd9e00810d07bdea841fc3a756
stderr: 'fatal: reference is not a tree: 17c09613fbe29fdd9e00810d07bdea841fc3a756' |
Contributor
|
Can one of the admins verify this patch? |
michaeljqzq
reviewed
Aug 9, 2019
...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
Outdated
Show resolved
Hide resolved
hvermis
requested changes
Aug 9, 2019
Contributor
hvermis
left a comment
hvermis
left a comment
There was a problem hiding this comment.
You should not add new API here. Instead delete all APIs that have reruntrigger in the path
hvermis
requested changes
Aug 9, 2019
Contributor
hvermis
left a comment
hvermis
left a comment
There was a problem hiding this comment.
Let's review this model internally first, please do not checkin this.
Contributor
|
@yaohaizh could you look at the Java sdk code gen error in CI? Thanks |
michaeljqzq
added
the
WaitForARMFeedback
hvermis
reviewed
Aug 28, 2019
...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
Outdated
Show resolved
Hide resolved
Contributor
hvermis
reviewed
Aug 28, 2019
...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
Outdated
Show resolved
Hide resolved
Contributor
Member
|
Hi @spagarwa could you pls address comments from review board? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hvermis
approved these changes
Feb 7, 2020
Member
|
hi @spargarwa, the PR is labelled with |
Contributor
Author
yungezz
removed
the
DoNotMerge
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
2 similar comments
|
No pipelines are associated with this pull request. |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
This was referenced Feb 7, 2020
Contributor
Author
Member
|
hi @anthony-c-martin could you pls approved the PR from "requested changes"? the PR cannot be merged due to change requested. thanks. |
anthony-c-martin
approved these changes
Feb 7, 2020
Contributor
Author
azure-sdk-for-python - Release
|
ssripadham
pushed a commit
to ssripadham/azure-rest-api-specs
that referenced
this pull request
Feb 21, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.