[BillingRP] New API to list transactions by invoice by asarkar84 · Pull Request #8319 · Azure/azure-rest-api-specs

asarkar84 · 2020-02-06T01:44:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Adding new fields to transactions API

Updated the field description

[BillingRP] New API to list transactions by invoice

azure-pipelines · 2020-02-06T01:45:09Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-06T01:47:42Z

Azure Pipelines failed to run 1 pipeline(s).

azure-pipelines · 2020-02-06T01:47:44Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-06T01:47:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-06T01:47:47Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-06T01:49:01Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2ab3b9d with merge commit d1df903. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-billing [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-02-06T01:49:02Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 2ab3b9d with merge commit d1df903. SDK Automation 13.0.17.20191226.1
️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs] [Release SDK Changes]
️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs] [Release SDK Changes]
️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]

⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-06T01:49:03Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2ab3b9d with merge commit d1df903. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Billing [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Billing.3.0.0-preview.nupkg
- Microsoft.Azure.Management.Billing.3.0.0-preview.snupkg

openapi-sdkautomation · 2020-02-06T01:49:04Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 2ab3b9d with merge commit d1df903. SDK Automation 13.0.17.20191226.1
⚠️preview/billing/mgmt/2017-02-27-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2017-04-24-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2018-11-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-02-06T01:49:07Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2ab3b9d with merge commit d1df903. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-billing [Logs] [Release SDK Changes]

azure-arm-billing-2.2.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
[npmPack] created ./dist/arm-billing.js in 735ms

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

pilor

🕐

Incorporating review comments

azure-pipelines · 2020-02-07T00:46:17Z

Azure Pipelines successfully started running 1 pipeline(s).

asarkar84 · 2020-02-08T00:09:40Z

@NullMDR Please merge the PR.

azure-pipelines · 2020-02-08T02:48:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-08T03:02:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-08T03:24:19Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-02-08T06:19:40Z

@asarkar84 Please fix the spellcheck

azure-pipelines · 2020-02-09T19:20:31Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-02-10T05:31:30Z

/azp run automation - sdk

azure-pipelines · 2020-02-10T05:31:40Z

Azure Pipelines successfully started running 1 pipeline(s).

* Adding new fields to transactions API Adding new fields to transactions API * Updated the field description Updated the field description * Updated few descriptions * [BillingRP] New API to list transactions by invoice [BillingRP] New API to list transactions by invoice * Incorporating review comments Incorporating review comments * Updated description * Updated transaction description * Updated description * Added unbilled to custom words

asarkar84 added 7 commits January 24, 2020 18:29

Adding new fields to transactions API

609e7a1

Adding new fields to transactions API

Merge remote-tracking branch 'upstream/master' into ansar/transactions

e6177df

Updated the field description

680ef78

Updated the field description

Merge remote-tracking branch 'upstream/master' into ansar/transactions

7d6b456

Updated few descriptions

5259473

Merge remote-tracking branch 'upstream/master' into ansar/transactions

d749b58

[BillingRP] New API to list transactions by invoice

0b7a7f7

[BillingRP] New API to list transactions by invoice

asarkar84 requested a review from wilcobmsft as a code owner February 6, 2020 01:44

openapi-assignment-bot bot assigned PhoenixHe-NV Feb 6, 2020

PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2020

pilor added the ARMReviewInProgress label Feb 6, 2020

pilor reviewed Feb 6, 2020

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json Show resolved Hide resolved

pilor suggested changes Feb 6, 2020

View reviewed changes

pilor added ARMChangesRequested and removed ARMReviewInProgress labels Feb 6, 2020

Incorporating review comments

0b09323

Incorporating review comments

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 7, 2020

pilor approved these changes Feb 7, 2020

View reviewed changes

Updated description

aaaad00

Updated transaction description

4c91f50

Updated description

7ba4442

Added unbilled to custom words

2ab3b9d

PhoenixHe-NV merged commit d1df903 into Azure:master Feb 10, 2020

Conversation

asarkar84 commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Feb 6, 2020

Uh oh!

azure-pipelines bot commented Feb 6, 2020

Uh oh!

azure-pipelines bot commented Feb 6, 2020

Uh oh!

azure-pipelines bot commented Feb 6, 2020

Uh oh!

azure-pipelines bot commented Feb 6, 2020

Uh oh!

openapi-sdkautomation bot commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

Uh oh!

pilor left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Feb 7, 2020

Uh oh!

asarkar84 commented Feb 8, 2020

Uh oh!

azure-pipelines bot commented Feb 8, 2020

Uh oh!

azure-pipelines bot commented Feb 8, 2020

Uh oh!

azure-pipelines bot commented Feb 8, 2020

Uh oh!

PhoenixHe-NV commented Feb 8, 2020

Uh oh!

azure-pipelines bot commented Feb 9, 2020

Uh oh!

PhoenixHe-NV commented Feb 10, 2020

Uh oh!

azure-pipelines bot commented Feb 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

asarkar84 commented Feb 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 6, 2020 •

edited

Loading