Skip to content

[Peering Service] apiVersion:2020-01-01-preview #8140

Merged
mmyyrroonn merged 6 commits intoAzure:masterfrom
rileymckenna:peering/2020-01-01-preview
Feb 10, 2020
Merged

[Peering Service] apiVersion:2020-01-01-preview #8140
mmyyrroonn merged 6 commits intoAzure:masterfrom
rileymckenna:peering/2020-01-01-preview

Conversation

@rileymckenna
Copy link
Contributor

@rileymckenna rileymckenna commented Jan 14, 2020

Added Registered Asn
Added Legacy Peering filter by Asn
Added filter to peering service countries
Added Sku to peering type
Added type to direct peering enum
Changed how contact details are stored
Added Sku to peering service

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 14, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 7a631dc with merge commit 0b92e30. SDK Automation 13.0.17.20191226.1
  • ⚠️sdk/peering/mgmt-v2019_08_01_preview [Logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringServicesImpl.java:[26,98] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringServiceImpl.java:[16,76] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringImpl.java:[20,62] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringsImpl.java:[26,77] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-peering: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringServicesImpl.java:[26,98] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringServiceImpl.java:[16,76] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringImpl.java:[20,62] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_08_01_preview/implementation/PeeringsImpl.java:[26,77] type argument com.microsoft.azure.management.peering.v2019_08_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/peering/mgmt-v2019_09_01_preview [Logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringServicesImpl.java:[26,98] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringServiceImpl.java:[16,76] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringsImpl.java:[26,77] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringImpl.java:[20,62] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-peering: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringServicesImpl.java:[26,98] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringServiceImpl.java:[16,76] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringsImpl.java:[26,77] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2019_09_01_preview/src/main/java/com/microsoft/azure/management/peering/v2019_09_01_preview/implementation/PeeringImpl.java:[20,62] type argument com.microsoft.azure.management.peering.v2019_09_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/peering/mgmt-v2020_01_01_preview [Logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringServiceImpl.java:[17,76] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringImpl.java:[20,62] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringsImpl.java:[26,77] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringServicesImpl.java:[26,98] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-peering: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringServiceImpl.java:[17,76] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringImpl.java:[20,62] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringsImpl.java:[26,77] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/peering/mgmt-v2020_01_01_preview/src/main/java/com/microsoft/azure/management/peering/v2020_01_01_preview/implementation/PeeringServicesImpl.java:[26,98] type argument com.microsoft.azure.management.peering.v2020_01_01_preview.implementation.PeeringServiceInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 14, 2020

        azure-sdk-for-go - Release

        ⚠️ warning [Logs] [Expand Details]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 14, 2020

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 7a631dc with merge commit 0b92e30. SDK Automation 13.0.17.20191226.1
        • ️✔️@azure/arm-peering [Logs]  [Release SDK Changes]
          [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/peeringManagementClient.js → ./dist/arm-peering.js...
          [npmPack] created ./dist/arm-peering.js in 387ms

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 14, 2020

        azure-sdk-for-net - Release

        failed [Logs] [Expand Details]
        • Generate from 7a631dc with merge commit 0b92e30. SDK Automation 13.0.17.20191226.1
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
        • Microsoft.Azure.Management.Peering [Logs]  [Release SDK Changes]
            Failed to create the package Microsoft.Azure.Management.Peering.
            Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=peering /v:n /p:SkipTests=true , {} 

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jan 14, 2020

          azure-sdk-for-python - Release

          ️✔️ succeeded [Logs] [Expand Details]

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          5 similar comments
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @rileymckenna rileymckenna changed the title Added Registered Peering Prefix/Asn [Peering Service] apiVersion:2020-01-01-preview Jan 15, 2020
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          4 similar comments
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          1 similar comment
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @allenjzhang
          Copy link
          Contributor

          /azp run

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 3 pipeline(s).

          @mmyyrroonn
          Copy link
          Contributor

          /azp run automation - sdk

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          Copy link
          Contributor

          @mmyyrroonn mmyyrroonn left a comment

          Choose a reason for hiding this comment

          The reason will be displayed to describe this comment to others. Learn more.

          a few comments. LGTM in general

          @mmyyrroonn
          Copy link
          Contributor

          /azp run automation - sdk

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Commenter does not have sufficient privileges for PR 8140 in repo Azure/azure-rest-api-specs

          @mmyyrroonn
          Copy link
          Contributor

          /azp run automation - sdk

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @mmyyrroonn
          Copy link
          Contributor

          @NullMDR Hi. I tried twice and based on the log, looks like we meet an error for .Net automation. Could you please check?

          @mmyyrroonn mmyyrroonn merged commit 0b92e30 into Azure:master Feb 10, 2020
          ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Labels

          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

          Projects

          None yet

          Development

          Successfully merging this pull request may close these issues.

          5 participants

          Comments