[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview by stack111 · Pull Request #8287 · Azure/azure-rest-api-specs

stack111 · 2020-02-03T18:25:27Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…to version 2020-04-01-preview

azure-pipelines · 2020-02-03T18:25:44Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-03T18:27:11Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 1a4bd6d with merge commit a20b17f. SDK Automation 13.0.17.20191226.1
⚠️maps/mgmt/2017-01-01-preview [Logs]
```
No file is changed.
```
⚠️maps/mgmt/2018-05-01 [Logs]
```
No file is changed.
```
️✔️preview/maps/mgmt/2020-02-01-preview [Logs] [Release SDK Changes]
- preview.maps.mgmt.2020-02-01-preview.zip

openapi-sdkautomation · 2020-02-03T18:27:12Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-02-03T18:27:14Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1a4bd6d with merge commit a20b17f. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-maps [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.rst'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.rst'

openapi-sdkautomation · 2020-02-03T18:27:14Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1a4bd6d with merge commit a20b17f. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-maps [Logs] [Release SDK Changes]

azure-arm-maps-1.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/mapsManagementClient.js → ./dist/arm-maps.js...
[npmPack] created ./dist/arm-maps.js in 269ms

openapi-sdkautomation · 2020-02-03T18:27:18Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1a4bd6d with merge commit a20b17f. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Maps [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Maps.1.0.2.nupkg
- Microsoft.Azure.Management.Maps.1.0.2.snupkg

azure-pipelines · 2020-02-03T19:19:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-03T19:34:15Z

Azure Pipelines successfully started running 1 pipeline(s).

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json

azure-pipelines · 2020-02-04T02:25:18Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2020-02-04T07:56:16Z

LGTM now.
I will approve once ARM signs off.

azure-pipelines · 2020-02-04T17:54:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-04T21:00:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-04T21:59:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-04T22:03:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-04T22:20:05Z

Azure Pipelines successfully started running 1 pipeline(s).

stack111 · 2020-02-04T22:33:51Z

@pilor the only warnings left are:

R3027 - TrackedResourceListByResourceGroup
The tracked resource, 'PrivateAtlas', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

R3028 - TrackedResourceListBySubscription
The tracked resource, 'PrivateAtlas', must have a list by subscriptions operation.
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

Does this make sense or should I suppress, because this is a nested resource?

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json

pilor · 2020-02-04T22:56:31Z

@pilor the only warnings left are:

R3027 - TrackedResourceListByResourceGroup
The tracked resource, 'PrivateAtlas', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

R3028 - TrackedResourceListBySubscription
The tracked resource, 'PrivateAtlas', must have a list by subscriptions operation.
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

Does this make sense or should I suppress, because this is a nested resource?

No, you don't need to support that for nested tracked resources. You can suppress

pilor

2 minor comments to fix but otherwise LGTM

azure-pipelines · 2020-02-04T23:10:40Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2020-02-05T02:07:33Z

/azp run

azure-pipelines · 2020-02-05T02:07:53Z

Azure Pipelines successfully started running 3 pipeline(s).

…iew/2020-02-01-preview (Azure#8287) * Adds base for updating Microsoft.Maps from version stable/2018-05-01 to version 2020-04-01-preview * Updates readme * Updates API version in new specs and examples * add private atlas resource and examples * fixing invalid format * fixing build validation errors * fixing style * removing 202 from review feedback * api version, inheritance, and feedback * removing 404 from examples and fixing version * fixing readme and remaining 404s * fixing typo * trying to fix missing input file * fixing output directory * adding tags to support docs preview * fixing List Operations name and sample * adding supressions and fix for operations * fixing the schema * removing isDataAction to fix * supress nested tracked, and remove move

stack111 and others added 5 commits February 2, 2020 11:46

Adds base for updating Microsoft.Maps from version stable/2018-05-01 …

b97d558

…to version 2020-04-01-preview

Updates readme

8ece92b

Updates API version in new specs and examples

adb6f1b

add private atlas resource and examples

67fbce1

fixing invalid format

deb01f2

openapi-assignment-bot bot assigned ArcturusZhang Feb 3, 2020

stack111 added the ARMReviewMeetingRequired label Feb 3, 2020

fixing build validation errors

8d23949

fixing style

b02b21e

stack111 added ARMReviewInProgress and removed ARMReviewMeetingRequired labels Feb 3, 2020

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

removing 202 from review feedback

e83c5cc

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

pilor reviewed Feb 3, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-04-01-preview/maps-management.json Outdated Show resolved Hide resolved

fixing output directory

0fc42ac

adding tags to support docs preview

1611a35

fixing List Operations name and sample

230a359

adding supressions and fix for operations

4c19150

fixing the schema

867f537

removing isDataAction to fix

72171a3

pilor reviewed Feb 4, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json Outdated Show resolved Hide resolved

pilor reviewed Feb 4, 2020

View reviewed changes

...ication/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json Show resolved Hide resolved

pilor approved these changes Feb 4, 2020

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2020

supress nested tracked, and remove move

1a4bd6d

ArcturusZhang approved these changes Feb 6, 2020

View reviewed changes

ArcturusZhang merged commit a20b17f into Azure:master Feb 6, 2020

Conversation

stack111 commented Feb 3, 2020

Contribution checklist:

Uh oh!

azure-pipelines bot commented Feb 3, 2020

Uh oh!

openapi-sdkautomation bot commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azure-pipelines bot commented Feb 3, 2020

Uh oh!

azure-pipelines bot commented Feb 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

ArcturusZhang commented Feb 4, 2020

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

stack111 commented Feb 4, 2020

Uh oh!

Uh oh!

Uh oh!

pilor commented Feb 4, 2020

Uh oh!

pilor left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Feb 4, 2020

Uh oh!

ArcturusZhang commented Feb 5, 2020

Uh oh!

azure-pipelines bot commented Feb 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-sdkautomation bot commented Feb 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 3, 2020 •

edited

Loading