Merged
Conversation
changelog: Internal, Reporting, Update query timeout in duplicate SSN report
It has been off in prod for a while, so let's make development match for everyone [skip changelog]
…es not yet activated (#9820) * check for active profile on reset disavowal * add tests to make sure proofing component stays * add changelog changelog: Internal, IdV, Do not destroy proofing component on password reset
* rebased wit main * return nil if in prod * add guard on liveness check for api image upload * add selfie param testing for standard doc auth * add selfie param testing for hybrid doc capture * send selfie to TrueID when not prod ans selfie enabled and requested by FE * rebased wit main * feature test to ensure selfie does not show in production * check that selfie is not displaying without selfie=true * test selfie behind staging and FF in hybrid mobile doc auth * update selfie validation to expect liveness_checking_enabled in params and not in constructor arg * rebased wit main * changelog: Upcoming Features, Document Authentication, DocAuth w/ selfie in lower environments * update doc auth selfie capture FF * resolve merge conflict * use sp_sesion to determine if selfie needed * image upload form attr readable liveness checkingenabled * re-add shared view guard * fix specs * make data-doc-auth-selfie-capture a boolean * remove selfie param from hybrid doc auth controller spec * test when selfie ff enabled * fix specs * happy linting * happy linting * use selfie_req'd from decorated sp session * remove unused code * use decorated_sp_session.selfie_required in image uploads controller * add selfie required to NullServiceProviderSession * remove leftover selfie=true params from spec * stub decorated sp session * fix document capture controller with use of decorated sp session * consolidate liveness check in images upload controller/form * update image uploads specs * check is prod in selfie req'd * test to ensure selfie_required is false when in prod * udpate specs since selfie req'd is handled in sp_session_decorator * update image upload controller spec to use sp_decorator.selfie_required? * rename include liveness in true id spec Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * linting * remove liveness_check_required? method in api_image_upload_form * combine before blocks * require biometric comparison for selfie analytics testing * fix string that should be boolean --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
changelog: Internal, Doc Auth, Add flag for ui customization.
* Added the ability to email IdV reports changelog: Internal, IdV, Added the ability to email IdV reports * remove ERB templating in preamble * create #as_csv method for array and keep #to_csv for string * move team ada emails to json array * JSON error fix * change team_ada_email to string changed the email to a string since there is a google group now. Also added the ability to add other emails if needed with an array in IdentityVerificationReport#emails * fix test
* Add missing territory to states list * Add state validation * changelog: User-Facing Improvements, DocAuth, Validate that state/territory is a valid state/territory in response from TrueID to allow users to address by reuploading their id * Remove length error from test * Don't add the new state/territory code * Combine :jurisdiction and :state validations
* Add new pii block for test * Get 'good_pii' test working * Add new required PII to tests * Use a shared error message text * Fix image uploads tests * changelog: User-Facing Improvements, DocAuth, Validate that state_id_number (license number) is present in response from TrueID to allow users to address by reuploading ids * Fix lint problem * Add keys to translation files * Fix puerto rican address fixture * Fix fixture files * Use general error message instead due to current content freeze * Put :state_id_number at the top of the file * Add test for missing state_id_number
* Remove unused flags images changelog: Internal, Code Quality, Remove unused image assets * Remove reference to removed vendor directory
changelog: Internal, Dependencies, Update dependencies to latest versions
changelog: Internal, Deployments, Ensure vendor folder exists
* updated headers to allow for iframe in dev docs * fix rubocop errors * move logic into secure_headers_concern * forgot the note/explanation * adding lookbook config param from docs * wrong if * add frame ancestor back * patch lookbook override of csp * remove old code and comments * Update config/application.yml.default Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update config/application.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * move csp middleware into if statement * Update config/application.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update config/application.yml.default Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update config/application.yml.default Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * lint fixes --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* Added minimal plumbing necessary to proceed with Ada-side work on selfies changelog: Internal,Selfie check,stub selfie_check_performed on DocAuth::Response Co-authored by Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored by Sonia Connolly <sonia.connolly@gsa.gov>
changelog: Internal, Documentation, Update data pull script documentation
…h Selfie (#9827) * Extract components for reuse * Use components from documents-step * Fix typo on prop passing * Fix same prop error for review step * changelog: User-Facing Improvements, In-Person Proofing, behind a featureflag that's off make the review-issues step match the documents step * Make lint fixes
* Rework typing to use shared types and utilities * changelog: Internal, In-Person Proofing, revise typescript types
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.52 to 1.10.53. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.52...v1.10.53) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…issues` Steps (#9838) changelog: Internal, In-Person Proofing, continue unifying document-capture and review-issues steps
* LG-11929 Update Daily Report Recipients changelog: Internal, Reporting, Streamline MKMR email config usage
mdiarra3
approved these changes
Jan 2, 2024
matthinz
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features