Skip to content

Jmax/lg 11942 update mock doc auth client to support selfie flag#9833

Merged
jmax-gsa merged 15 commits intomainfrom
jmax/LG-11942-update-mock-doc-auth-client-to-support-selfie-flag
Dec 27, 2023
Merged

Jmax/lg 11942 update mock doc auth client to support selfie flag#9833
jmax-gsa merged 15 commits intomainfrom
jmax/LG-11942-update-mock-doc-auth-client-to-support-selfie-flag

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Dec 27, 2023

🎫 Ticket

LG-11942

🛠 Summary of changes

Added the minimal changes necessary to allow team Ada to proceed with our side of the selfie work. Incorporated team Timnit's current work.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Verify that the new controller specs for this (spec/controllers/idv/image_uploads_controller.rb:349) runs and passes.
  • Verify that all existing specs still pass

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

New spec run:
RSpec Compilation started at Wed Dec 27 13:42:19

bundle exec rspec --format documentation /Users/johnamaxwell/projects/identity-idp/spec/controllers/idv/image_uploads_controller_spec.rb:346
Run options: include {:locations=>{"./spec/controllers/idv/image_uploads_controller_spec.rb"=>[346]}}

Randomized with seed 30508

Idv::ImageUploadsController
  #create
    when image upload succeeds
      returns a successful response and modifies the session
      tracks events
      selfie included
        returns a successful response and modifies the session
      encrypted document storage is enabled
        includes image fields in attempts api event
      but doc_pii validation fails
        due to invalid State
          tracks state validation errors in analytics
        encrypted document storage is enabled
          includes image references in attempts api
        due to invalid Name
          tracks name validation errors in analytics
        but doc_pii validation fails due to invalid DOB
          tracks dob validation errors in analytics
        but doc_pii validation fails due to missing state_id_number
          tracks state_id_number validation errors in analytics

Top 0 slowest examples (0 seconds, 0.0% of total time):

Finished in 0.84071 seconds (files took 1.84 seconds to load)
9 examples, 0 failures

Randomized with seed 30508


RSpec Compilation finished at Wed Dec 27 13:42:22

@jmax-gsa jmax-gsa force-pushed the jmax/LG-11942-update-mock-doc-auth-client-to-support-selfie-flag branch from 2b9be6e to 24d3ae6 Compare December 27, 2023 18:34
@jmax-gsa jmax-gsa marked this pull request as ready for review December 27, 2023 18:47
Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired on this; it appears to match all the requirements for LG-11942; I looked it over once more and think it came out pretty well. Thanks!

@jmax-gsa jmax-gsa merged commit b97970e into main Dec 27, 2023
@jmax-gsa jmax-gsa deleted the jmax/LG-11942-update-mock-doc-auth-client-to-support-selfie-flag branch December 27, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants