Conversation
…apture and review-issues steps
charleyf
changed the title
document-capture and review-issues Steps
app/javascript/packages/document-capture/components/documents-step.jsx
Outdated
Show resolved
Hide resolved
zachmargolis
approved these changes
Dec 29, 2023
Comment on lines
+37
to
+38
| defaultSideProps: DefaultSideProps; | ||
| selfieValue: ImageValue; |
Contributor
There was a problem hiding this comment.
I think we try to avoid any as much as we can so I pushed 89b88e5, it passed npm run typecheck
Contributor
Author
There was a problem hiding this comment.
Thanks! I wasn't figuring the typing I needed out easily. Appreciate the help!
charleyf
deleted the
charley/lg-11893-error-messages-on-liveness-fail-one
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11893
🛠 Summary of changes
These changes extract and reuse a component for both the
document-captureandreview-issuesstep rather than doing it twice in two different places. This is not directly related to the ticket, but this cleanup is in the same file, so doing this first should make the work in coming PRs easier.📜 Testing Plan
Log in to the app, enter the IDV flow on a phone and check that the front/back upload boxes still look and behave as expected.