Rework review-step Typing to use Shared Types and Utilities#9836
Merged
Rework review-step Typing to use Shared Types and Utilities#9836
review-step Typing to use Shared Types and Utilities#9836Conversation
charleyf
changed the title
review-step Typing to use Shared Types and Utilities
zachmargolis
approved these changes
Dec 28, 2023
aduth
reviewed
Jan 2, 2024
app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11906
🛠 Summary of changes
This PR is a followup to fix some typing oddness we noticed here. It ended up changing the typing in one file to use the same
FormStepComponentPropsutility as we use other places.📜 Testing Plan
yarn run tsc