Conversation
changelog: Internal, IdV, Do not destroy proofing component on password reset
| end | ||
|
|
||
| def mark_profile_inactive | ||
| return if user.active_profile.blank? |
Contributor
There was a problem hiding this comment.
Nice one-line fix! Do we want to destroy the proofing component if they have an active profile? I thought we never destroyed proofing components.
Contributor
Author
There was a problem hiding this comment.
When a profile is minted, the proofing component gets saved to that profile in an immutable kind of form so it will still be there. If a user goes through IdV again then they will have an overwritten proofing_component table so it's probably not as important.
soniaconnolly
approved these changes
Dec 21, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! Tried it out, still had a proofing component.
theabrad
deleted the
abrad-lg-11839-proofing-component-password-reset
branch
matthinz
reviewed
Dec 21, 2023
| return if user.active_profile.blank? | ||
|
|
||
| user.active_profile&.deactivate(:password_reset) | ||
| Funnel::DocAuth::ResetSteps.call(@user.id) |
Contributor
There was a problem hiding this comment.
Does it matter that we're skipping this doc auth log thing in this case?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11839
🛠 Summary of changes
If a user goes through IdV and choses to reset their password at the enter password step and then disavow that password reset, their proofing components gets deleted. We want to keep those proofing components until a user completed IdV so that they get minted with the profile. This PR fixes that. This should not matter because if a user resets their password they have to go through IdV again, but this eliminates an edge case.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.