LG-10396 Update PII Validation for State/Territory#9797
Merged
Conversation
charleyf
commented
Dec 19, 2023
…ritory is a valid state/territory in response from TrueID to allow users to address by reuploading their id
charleyf
requested review from
a team and
amirbey
and removed request for
a team
eileen-nava
reviewed
Dec 19, 2023
night-jellyfish
approved these changes
Dec 21, 2023
Contributor
There was a problem hiding this comment.
I tried it out locally and it worked!
I first tried with a successful file (spec/fixtures/ial2_test_credential.yml) and saw doc auth succeed. Then I edited that file to have a really long state abbreviation (basically just adding a bunch of y's). That failed as expected, with the general error of Try taking new pictures.
It does seem like maybe an error of doc_auth.errors.alerts.address_check might be more communicative, but maybe that's a future improvement or a question for design.
charleyf
deleted the
charley/lg-10396-update-pii-validation-for-state/territory
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10396
🛠 Summary of changes
This work updates our validations to required that the response we get from TrueID includes the OCRed value for "State" from the license image we sent. This error is currently surfacing later in the process, so this PR actually just moves it up to a place where the user can actually address it (by reuploading ID images).