Conversation
…number (license number) is present in response from TrueID to allow users to address by reuploading ids
charleyf
changed the title
eileen-nava
reviewed
Dec 20, 2023
charleyf
commented
Dec 20, 2023
…-is-read-from-id-document
amirbey
approved these changes
Dec 21, 2023
Contributor
There was a problem hiding this comment.
LGTM ... i think you should consider adding a test case in the image_uploads_controller_spec.rb
also think @eileen-nava suggestion is a beneficial change that quick and easy 👍🏿
charleyf
commented
Dec 21, 2023
| end | ||
| end | ||
|
|
||
| context 'but doc_pii validation fails due to missing state_id_number' do |
Contributor
Author
There was a problem hiding this comment.
@amirbey Adding a test is a good idea. Did it here.
charleyf
deleted the
charley/lg-10423-validate-document-id-number-is-read-from-id-document
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10423
🛠 Summary of changes
This PR adds a validation on the
state_id_numberwhich is also known as the Document ID Number.