LG-11906 Update Review Step UI with Selfie to Match Document Step with Selfie#9827
Merged
LG-11906 Update Review Step UI with Selfie to Match Document Step with Selfie#9827
Conversation
…tureflag that's off make the review-issues step match the documents step
app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/review-issues-step.tsx
Show resolved
Hide resolved
night-jellyfish
approved these changes
Dec 23, 2023
Contributor
night-jellyfish
left a comment
There was a problem hiding this comment.
I left a couple of questions for my own learning, but I also tested this out locally and saw the expected behavior.
The headers and selfie step look identical to me.
I did notice one strange thing when I tested on mobile, but I suspect it's not from this branch. So I am going to post it in the Slack thread instead.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11906
🛠 Summary of changes
This PR extracts the two components Daweis created for the
documents-stepand adds them to thereview-step.A little more explanation since this is confusing:
documents-step.documents-step. It's thereview-stepwhich is basically the same, but also handles the errors from the earlier submission.📜 Testing Plan
getSelfieCaptureEnabledto returntrueas a work around.review-steppage. The numbered headers and selfie step should look the same as your screenshot from earlier.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: