Skip to content

LG-11906 Update Review Step UI with Selfie to Match Document Step with Selfie#9827

Merged
charleyf merged 8 commits intomainfrom
charley/lg-11906-update-review-step-ui
Dec 28, 2023
Merged

LG-11906 Update Review Step UI with Selfie to Match Document Step with Selfie#9827
charleyf merged 8 commits intomainfrom
charley/lg-11906-update-review-step-ui

Conversation

@charleyf
Copy link
Contributor

@charleyf charleyf commented Dec 22, 2023

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-11906

🛠 Summary of changes

This PR extracts the two components Daweis created for the documents-step and adds them to the review-step.

A little more explanation since this is confusing:

  • When a user uploads documents they're on the documents-step.
  • If they upload a failing (blurry, etc) picture and submit.
  • They land on a very similar page (with front/back/selfie uploads)
  • But that's actually not the same documents-step. It's the review-step which is basically the same, but also handles the errors from the earlier submission.

📜 Testing Plan

⚠️ Notes in this thread on enabling the selfie feature as of 12/22/2023 ⚠️ Turning on the featureflag doesn't show the selfie box right now. Testing workaround is in the first step.

  • With the selfie feature flag on. Or, you can also force getSelfieCaptureEnabled to return true as a work around.
  • Go to the Front/back selfie upload page.
  • You should see the numbered headings and selfie box per this PR. Take a screenshot of this page for comparing to a later step.
  • Upload one of the yaml files that cause the submission to fail for all three fields: front, back, and selfie.
  • Click "Submit"
  • Click the button to try again online.
  • The page you see now is the review-step page. The numbered headers and selfie step should look the same as your screenshot from earlier.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:
After:
-->

@charleyf charleyf marked this pull request as ready for review December 22, 2023 21:41
@charleyf charleyf changed the title Charley/lg 11906 update review step UI LG-11906 Update Review Step UI with Selfie to Match Document Step with Selfie Dec 22, 2023
Copy link
Contributor

@night-jellyfish night-jellyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of questions for my own learning, but I also tested this out locally and saw the expected behavior.

Before initial failed upload (in the "document" step): 11906-document-step
After a failed upload (in the "review issues" step): 11906-review-issues-step

The headers and selfie step look identical to me.

I did notice one strange thing when I tested on mobile, but I suspect it's not from this branch. So I am going to post it in the Slack thread instead.

@charleyf charleyf merged commit 173519b into main Dec 28, 2023
@charleyf charleyf deleted the charley/lg-11906-update-review-step-ui branch December 28, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants