Skip to content

Remove unused flags images#9817

Merged
aduth merged 2 commits intomainfrom
aduth-rm-flags-images
Dec 22, 2023
Merged

Remove unused flags images#9817
aduth merged 2 commits intomainfrom
aduth-rm-flags-images

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 21, 2023

🛠 Summary of changes

Removes two unused flags images.

We use a flags sprite for the phone input component, but it is loaded directly from the node_modules package using the asset pipeline:

# Add additional assets to the asset load path
Rails.application.config.assets.paths.push(
'node_modules/intl-tel-input/build/img',

See also:

The directory name is also not correct, since the package we use is intl-tel-input, not intl-tel-number.

📜 Testing Plan

Verify there is no regression in the appearance of flags in the phone input component:

  1. Go to http://localhost:3000
  2. Sign in
  3. Click "Add a phone number" from your account dashboard
  4. (Reauthenticate if prompted)
  5. Verify the phone input shows country flags in the dropdown

👀 Screenshots

There are no visual changes, but here's the phone dropdown after these changes as verification that there is no regression:

image

changelog: Internal, Code Quality, Remove unused image assets
@aduth aduth merged commit 7ea3971 into main Dec 22, 2023
@aduth aduth deleted the aduth-rm-flags-images branch December 22, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants