Merged
Conversation
* Add lint to standardize i18n keys named with HTML * Makes sure they actually contain HTML * Update HTML check to check across all locales, so that only one string needs the _html changelog: Internal, Source code, Make HTML escaping in translations consistent
Changelog: Internal, IALMAX, Create allowlist of service providers in the application config that can utilize the IALMax flow Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove DocAuthController, spec, and routes changelog: Internal, Identity verification, remove unsupervised proofing flow state machine controller * Remove unneeded /doc_auth from link_sent polling route * Add back deprecated route without alias for 50/50 state * Add legacy redirect for /doc_auth/:step routes
The previously added legacy route left the user on /verify/doc_auth/welcome which would give them a 404 when they click Continue. [skip changelog] Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
* move string to error config * WIP: suggestion for forbidden password * use includes instead of indexof * add test for password strength, cleanup * changelog: User-facing improvements, password, improve messaging when user enters a forbidden password * Address PR comment: typescript declaration
…Method) (#8716) * changelog: User-Facing Improvements, Error screens, Removed pathway and error page for stand alone error messaging * remove unneeded context block * flatten context out defining multiple MFA' * remove unused i18n keys from yml files * undelete error view and the related locale phrases. add to error method in the controller the redirect to please try again view * fix lint errors * change passed parameter to string * revert error method to remove unneeded redirect * tidy up line break
* LG-10214 Suspended User Create Account Flow changelog: User-Facing Improvements, Suspension, Add email send on create account
Add mfa_created_at to Multi-Factor Authentication event changelog: Internal, Analytics, Add mfa_created_at to Multi-Factor Authentication event
changelog: Internal, In-person proofing, Refresh USPS token in job [LG-9433](https://cm-jira.usa.gov/browse/LG-9433) Right now, the responsibility for renewing the authentication token lies with the methods calling out to the USPS API for any reason. This can delay requests to, for example, search for nearby post offices, as they have to first do the authentication and then do the work. Creating a USPS authentication token refresh job takes the responsibility away from the other calls to the API. They still have the logic and ability to do so as a failsafe in case all the refresh jobs fail, but if the jobs are working properly they should never need to make the call. We also added a stubbed method for testing errored requests. Tested in the Joy Sandbox and locally successfully. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…person proofing (#8731) * log presence of address line 2 on enroll changelog: Internal, In-Person Proofing, Log the presence of address line 2 when enrolling in IPP
#8734) * send only address line 1 to USPS changelog: Internal, In-person proofing, Send only address line 1 to USPS when creating an enrollment
* Set banner text conditionally changelog: User-Facing Improvements, Success Banners, Idv success * Add success message for resend * Add translations * Extend existing verify by mail spec to check success banner * Test success banner on resend * Shorten line * Remove typo
…8723) * Remove redirect from WebAuthn authenticate changelog: Upcoming Features, Face or Touch Unlock, Remove requirement for available platform authenticator during authentication * Remove platform available check from webauthn input unhide * Create show.html.erb_spec.rb * Reshuffle specs for webauthn visibility * Enable platform auth setup in test
* remove flow_session flow_path preserved for 50/50 state continuity * [skip changelog] * remove remaining flow_path[:flow_session] * remove comment
* Modifiied CAT Update button for Spanish * changelog: User-Facing Improvements, update cta text, change Update CTA in Spanish
* LG-10290: Fix F/T unlock cancel sign-in redirect changelog: Upcoming Features, Face or Touch Unlock, Fix redirect for cancelled sign-in * Remove unused ID reference
* check throttled before increment for gpo * rate limit gpo immediately * happy linting * happy linting * processes hybrid_handoff send link request for max attempts * happy linting * changelog: Identity Verification: Process form submission on final attempt before rate limiting * changelog: User-Facing Improvements, Identity Verification, Process form submission on final attempt before rate limiting * update failed attempts count based on max attempts * rename context for gpo verificaiton rate limited tests
* LG-10124: implementation of notification sender. changelog: Internal, Maintenance, SMS/Voice notification. * LG-10124: refactor based on jira card update. * LG-10124: remove subclassing, since we are ok with code duplications. * LG-10124: alias method. * LG-10124: cleanup
changelog: Bug Fixes, Session Timeout, Fix appearance of session timeout modal
aduth
approved these changes
Jul 10, 2023
mdiarra3
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(redo of #8746 with the correct branch name)
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features