Skip to content

LG-10195: Log presence of address line 2 when enrolling a user in in-person proofing#8731

Merged
tomas-nava merged 4 commits intomainfrom
tomas/lg-10195-log-when-more-than-one-address-line
Jul 7, 2023
Merged

LG-10195: Log presence of address line 2 when enrolling a user in in-person proofing#8731
tomas-nava merged 4 commits intomainfrom
tomas/lg-10195-log-when-more-than-one-address-line

Conversation

@tomas-nava
Copy link
Contributor

@tomas-nava tomas-nava commented Jul 7, 2023

🎫 Ticket

LG-10195

🛠 Summary of changes

Add a boolean second_address_line_present parameter to the 'USPS IPPaaS enrollment created' event that is true when the user has entered a second address line.

📜 Testing Plan

  1. Go through the IPP flow, create an enrollment
  2. Check the log for a 'USPS IPPaaS enrollment created' event
  3. The second_address_line_present parameter on the event should be true if you entered a second address line, and false otherwise. Check different DAV configurations:
    1. DAV false, address line 2 present/missing in current address
    2. DAV true, address line 2 present in state ID address, state ID matches residential
    3. DAV true, address line 2 present in state ID address, state ID doesn't match residential, address line 2 missing from residential address

changelog: Internal, In-Person Proofing, Log the presence of address line 2 when enrolling in IPP
@tomas-nava tomas-nava requested review from a team and allthesignals July 7, 2023 14:45
MOCK_IDV_APPLICANT_WITH_PHONE = MOCK_IDV_APPLICANT_WITH_SSN.merge(phone: '12025551212').freeze

MOCK_IDV_APPLICANT_WITH_ADDRESS_LINE_2 = MOCK_IDV_APPLICANT_WITH_SSN.merge(
address2: MOCK_IDV_APPLICANT_STATE_ID_ADDRESS[:identity_doc_address2],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reuses the existing address2, right? What if we added a new, unused address so we can make sure it's checking the correct address2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're checking the presence rather than the content of address2, so I don't think we need to worry about that (if I'm interpreting your comment correctly). When I was looking closer at the test, though, I decided to remove this constant and set values in the tests themselves instead, that's in 012477e

@tomas-nava tomas-nava merged commit 8139bcd into main Jul 7, 2023
@tomas-nava tomas-nava deleted the tomas/lg-10195-log-when-more-than-one-address-line branch July 7, 2023 21:35
This was referenced Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants