LG-10195: Log presence of address line 2 when enrolling a user in in-person proofing#8731
Merged
tomas-nava merged 4 commits intomainfrom Jul 7, 2023
Merged
Conversation
changelog: Internal, In-Person Proofing, Log the presence of address line 2 when enrolling in IPP
added 2 commits
July 7, 2023 08:30
zachmargolis
approved these changes
Jul 7, 2023
lib/idp/constants.rb
Outdated
| MOCK_IDV_APPLICANT_WITH_PHONE = MOCK_IDV_APPLICANT_WITH_SSN.merge(phone: '12025551212').freeze | ||
|
|
||
| MOCK_IDV_APPLICANT_WITH_ADDRESS_LINE_2 = MOCK_IDV_APPLICANT_WITH_SSN.merge( | ||
| address2: MOCK_IDV_APPLICANT_STATE_ID_ADDRESS[:identity_doc_address2], |
Contributor
There was a problem hiding this comment.
this reuses the existing address2, right? What if we added a new, unused address so we can make sure it's checking the correct address2?
Contributor
Author
There was a problem hiding this comment.
We're checking the presence rather than the content of address2, so I don't think we need to worry about that (if I'm interpreting your comment correctly). When I was looking closer at the test, though, I decided to remove this constant and set values in the tests themselves instead, that's in 012477e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10195
🛠 Summary of changes
Add a boolean
second_address_line_presentparameter to the'USPS IPPaaS enrollment created'event that istruewhen the user has entered a second address line.📜 Testing Plan
'USPS IPPaaS enrollment created'eventsecond_address_line_presentparameter on the event should betrueif you entered a second address line, andfalseotherwise. Check different DAV configurations: