Skip to content

Fix session timeout modal styles#8743

Merged
aduth merged 1 commit intomainfrom
aduth-modal-stylesheet
Jul 10, 2023
Merged

Fix session timeout modal styles#8743
aduth merged 1 commit intomainfrom
aduth-modal-stylesheet

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 10, 2023

🛠 Summary of changes

Fixes an issue where the session timeout modal styles are missing.

Likely a regression of #8571, where modal is susceptible to the same issue as Language Picker described in the original pull request description, since it is also rendered in the base layout:

This was originally going to include a refactor of LanguagePickerComponent to have a component stylesheet, but there's an issue with how we render the "stylesheet once" tags which is incompatible with components rendered as part of the base layout. This will need to be fixed first.

👀 Screenshots

Before After
Screen Shot 2023-07-10 at 2 45 49 PM Screen Shot 2023-07-10 at 2 46 53 PM

changelog: Bug Fixes, Session Timeout, Fix appearance of session timeout modal
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit a58a8d7 into main Jul 10, 2023
@aduth aduth deleted the aduth-modal-stylesheet branch July 10, 2023 19:00
aduth added a commit that referenced this pull request Jul 10, 2023
changelog: Bug Fixes, Session Timeout, Fix appearance of session timeout modal
@aduth aduth mentioned this pull request Jul 10, 2023
This was referenced Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants