LG-10177: Always show Face / Touch Unlock in list of configured MFAs#8723
Merged
LG-10177: Always show Face / Touch Unlock in list of configured MFAs#8723
Conversation
5 tasks
aduth
commented
Jul 6, 2023
Contributor
Author
There was a problem hiding this comment.
It may be easiest to review this file with whitespace changes hidden:
https://github.com/18F/identity-idp/pull/8723/files?w=1
changelog: Upcoming Features, Face or Touch Unlock, Remove requirement for available platform authenticator during authentication
752dcc6 to
0227d00
Compare
jmdembe
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10177
🛠 Summary of changes
Removes behavior which would prevent a user from attempting to authenticate an existing WebAuthn configuration on a device which does not have a platform authenticator available (
isUserVerifyingPlatformAuthenticatorAvailable).Why? Because the user's credential may be accessible via cloud services regardless of the availability of a local platform authenticator. For example, a MacBook laptop that does not have a thumbprint reader may still be able to use an iCloud-synced WebAuthn credential.
📜 Testing Plan
👀 Screenshots
† Note that the Firefox experience of prompting for Security Key here is far from ideal, though this is not the ideal use-case for platform authenticators, since Firefox does not have any support for Passkeys at all.