Merged
Conversation
Sgtpluck
commented
Jun 30, 2023
Sgtpluck
commented
Jun 30, 2023
Contributor
Author
There was a problem hiding this comment.
this file is noisy bc i updated the test file to reduce duplication/make it clearer what was being tested.
i introduced tests on line 35 and line 200 specific to IALMAX
mitchellhenke
approved these changes
Jun 30, 2023
Sgtpluck
force-pushed
the
dmm/LG-9958/constrain-ialmax-to-existing-integrations
branch
2 times, most recently
from
805c9ec to
b3bffd6
Compare
zachmargolis
reviewed
Jul 3, 2023
zachmargolis
reviewed
Jul 3, 2023
config/application.yml.default
Outdated
Contributor
There was a problem hiding this comment.
I would consider leaving the prod value blank and putting the "real" values in S3 only
Contributor
Author
There was a problem hiding this comment.
oh i am happy to do that but don't know how -- will you show me? (we can do it on wednesday, i'm not merging this in today)
Contributor
Author
There was a problem hiding this comment.
values were added 07/06
Sgtpluck
force-pushed
the
dmm/LG-9958/constrain-ialmax-to-existing-integrations
branch
2 times, most recently
from
0530e62 to
38014e8
Compare
mmagsa
approved these changes
Jul 5, 2023
…at can utilize the IALMax flow
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Sgtpluck
force-pushed
the
dmm/LG-9958/constrain-ialmax-to-existing-integrations
branch
from
042b326 to
9be8099
Compare
Sgtpluck
deleted the
dmm/LG-9958/constrain-ialmax-to-existing-integrations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
add allow list config for IALMAX
🛠 Summary of changes
As a first step to deprecating IALMAX, we would like to constrain IALMAX to existing partners/integrations. This change introduces an allowlist of issuers for IALMAX, and if a partner is not on the allowlist, they will be unable to utilize the IALMAX flow.