LG-10205: Don't rate limit users on their last attempt#8727
Merged
Conversation
amirbey
changed the title
amirbey
changed the title
soniaconnolly
approved these changes
Jul 10, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! Tried it out and it worked as expected.
…tempt before rate limiting
…orm submission on final attempt before rate limiting
amirbey
force-pushed
the
amirbey/LG-10205-rate-limit
branch
from
7c0c2f1 to
9ecd1fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10205
🛠 Summary of changes
On the final attempt, process the GPO Verification submission instead of immediately failing.
On the final attempt, process the HybridHandoff send link submission instead of immediately failing.
📜 Testing Plan
Automated testing
Manually:
GPO Code:
HybridHandoff