Skip to content

LG-9657: Improve messaging for forbidden password feedback#8726

Merged
jmdembe merged 7 commits intomainfrom
LG-9657-improve-password-feedback
Jul 7, 2023
Merged

LG-9657: Improve messaging for forbidden password feedback#8726
jmdembe merged 7 commits intomainfrom
LG-9657-improve-password-feedback

Conversation

@jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Jul 6, 2023

🎫 Ticket

LG-9657: Improve messaging for forbidden password feedback

🛠 Summary of changes

This PR adds more targeted messaging to prevent users from creating a password that is on the forbidden passwords list.

📜 Testing Plan

On https://localhost:3000

  • Follow steps to create a new account. Use an e-mail that you will remember
  • On "Choose a password" page, set the password to your email, or another value like gsa or Login.gov
  • Notice that above the password strength bar, the hint reads "Avoid using phrases that are easily guessed, such as parts of your email or personal dates."

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before After
Current image of choose a password page on Login.gov After image of choose a password page on Login.gov

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on the specs, but LGTM otherwise 👍

@jmdembe jmdembe merged commit 402aaa6 into main Jul 7, 2023
@jmdembe jmdembe deleted the LG-9657-improve-password-feedback branch July 7, 2023 13:30
This was referenced Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants