LG-9939 Final doc_auth_controller removal#8705
Merged
soniaconnolly merged 5 commits intomainfrom Jul 6, 2023
Merged
Conversation
changelog: Internal, Identity verification, remove unsupervised proofing flow state machine controller
jmhooper
approved these changes
Jul 6, 2023
…oc-auth-controller-removal
jmhooper
added a commit
that referenced
this pull request
Apr 16, 2024
…eStep` The `add_cost` and `add_costs` methods both create `SpCost` records for FlowStateMachine steps the inherit from `Idv::Steps::DocAuthBaseStep`. We [removed the `FlowStateMachine`](#8705) from all paths that lead to the creation of an `SpCost` record about a year ago. The [`FlowStateMachine`](https://github.com/18F/identity-idp/blob/main/app/services/flow/flow_state_machine.rb) and associated [`Idv::Steps::DocAuthBaseStep`](https://github.com/18F/identity-idp/blob/main/app/services/idv/steps/doc_auth_base_step.rb) remain, however, to support the in-person flow. The in-person flow does not create `SpCost` records in the `FlowStateMachine`. These methods, like many methods in `FlowStateMachine` relics are unused. We left these unused methods because it was assumed that the `FlowStateMachine` would be removed from the in-person flow shortly after it was removed from the unsupervised flow. That has not been the case so this commit does some cleanup to remove them. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Apr 16, 2024
…eStep` (#10448) The `add_cost` and `add_costs` methods both create `SpCost` records for `FlowStateMachine` steps that inherit from `Idv::Steps::DocAuthBaseStep`. We [removed the `FlowStateMachine`](#8705) from all paths that lead to the creation of an `SpCost` record about a year ago. The [`FlowStateMachine`](https://github.com/18F/identity-idp/blob/main/app/services/flow/flow_state_machine.rb) and associated [`Idv::Steps::DocAuthBaseStep`](https://github.com/18F/identity-idp/blob/main/app/services/idv/steps/doc_auth_base_step.rb) remain, however, to support the in-person flow. The in-person flow does not create `SpCost` records in the `FlowStateMachine`. These methods, like many methods in `FlowStateMachine` relics, are unused. We left these unused methods because it was assumed that the `FlowStateMachine` would be entirely removed from the in-person flow shortly after it was removed from the unsupervised flow. That has not been the case so this commit does some cleanup to remove them. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9939
🛠 Summary of changes
Final removal of DocAuthController.
Do not merge until #8699 is deployed and we check logs to confirm nothing is going through these routes (no log entries containing DocAuthController).
📜 Testing Plan