Modified CTA Update button for Spanish#8733
Merged
gina-yamada merged 4 commits intomainfrom Jul 10, 2023
Merged
Conversation
carmenrosalop
approved these changes
Jul 7, 2023
carmenrosalop
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks Gina!
night-jellyfish
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10085 Implementation: Change the CTA "Update" for Spanish translations for the 6 views listed below
🛠 Summary of changes
Change the "Update" CTA button in Spanish from "Actualización" to "Actualizar" on these 6 pages:
Update the information on your ID, Update your current address, Update your SSN for In Person...
Update your current address, Update your SSN for Doc Upload...
Update your password...
📜 Testing Plan
Each check box corresponds with a view above, 6 checkboxes below/6 views above.
/verify/in_person/verify_info/es/verify/in_person/state_idconfirm the button has been updated to "Actualizar"./es/verify/in_person/addressconfirm the button has been updated to "Actualizar"./es/verify/in_person/ssnconfirm the button has been updated to "Actualizar"./verify/verify_info/es/verify/addressconfirm the button has been updated to "Actualizar"./es/verify/ssnconfirm the button has been updated to "Actualizar"./accountand click on Edit password under Your Account. You will be taken to/manage/passwordes/manage/password✅ Approvals
The original request was for 3 views. It was discovered that 3 more views would be affected. Rather than only modifying the CAT Update in Team Joy's views only, Carmen asked Team Ada and Katherine for approval so that all of the buttons would be consistent. Both teams gave approval, see LG-10085 description for slack threads/approvals.
👀 Screenshots
es/verify/in_person/state_id
es/verify/in_person/address
es/verify/in_person/ssn
es/verify/address
es/verify/ssn
/es/mange/password