Conversation
* Remove unused DocAuthController#update_if_skipping_upload before action * Rename DocumentCaptureController before action * Rename LinkSentController before action * Rename upload language tags to hybrid_handoff * Rename upload spec helpers to hybrid_handoff [skip changelog]
Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
AWS updated their Supported countries and regions (SMS channel) to say that Australia needs sender ID, but we're not seeing that, so we added a list of SENDER_ID_EXCEPTION_COUNTRIES and put Australia on it. https://docs.aws.amazon.com/pinpoint/latest/userguide/channels-sms-countries.html We don't want to try to send a sender_id to a country where it is not registered. changelog: Internal, International SMS configuration, Update Australia to not require a sender_id --------- Co-authored-by: Gina Yamada <gina.yamada@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: Zach Margolis <zach.margolis@gsa.gov>
) * LG-9973: Implement new default Sign In page from A/B test results changelog: User-Facing Improvements, Sign In, Update layout of Sign In page to reflect results of recent A/B test * Improve mobile appearance of tab navigation * Add upstream reference * Incorporate upstream button styling improvements See: 18F/identity-design-system#359
LG-10013 - nil out fraud_review_pending_at In Profile#activate_after_passing_in_person, because in-person proofing verifies them. changelog: Bug Fix,in-person idv,clear profile columns after in-person proofing
…sued ID" page (#8554) * LG-10052 Add validation to zipcode on state_id * LG-10052 Fix lint issue * changelog: User-Facing Improvements, In-person proofing, Add validation to zip code on State Id View * sort fields, add cleave formatting * add test for zipcode validation * remove unneeded variables from test * LG-10052 Clean up unused items --------- Co-authored-by: Tomas Apodaca <Thomas.Apodaca@gsa.gov>
* Avoid database query associated with heartbeat poll changelog: Internal, Performance, Avoid database query for session heartbeat polling * Restore flash redirect behavior to ApplicationController session_expired behavior applies to all logged-out screens, so this should continue to exist (for now) in ApplicationController. it also simplifies the diff * Fix handling for legacy timeout parameter * Restore legacy endpoints for initial deploy To avoid issues for 50/50 deploy and for clients running stale version of JavaScript, to be reverted in follow-on pull request * Initialize session timeout JavaScript with timeout URL See: #7966 (comment) * Reincorporate timeRemaining safeguards See: - https://github.com/18F/identity-idp/pull/7966/files#r1207202821 - #8117 * Remove route for deleted SessionsController#destroy * Only update last_request_at if still live * Add specs for SessionsController#update * Add specs for updated redirect_with_flash_if_timeout * Add specs for SessionsController#update analytics * Update spec session value * Simplify diff
…ndoff (#8557) * LG-8830: Replace RedoDocumentCaptureAction with redirect to hybrid handoff. changelog: Internal, Refactoring, Replace FSM RedoDocumentCaptureAction * Replace CancelLinkSentAction with a link in LinkSent show template It no longer renders the shared _back template. --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>
* Add location to events logged by promptOnNavigate Include _where_ the user was when they encountered an onbeforeunload popup. [skip changelog] * Say "path" instead of "location" "location" is used more in the sense of "where on the page was this thing." Also, since we're not actually passing it as an option (or testing that), just always use window.location.pathname.
Syntax changes: - top-level describe, shared_examples are now RSpec.describe, RSpec.shared_examples changelog: Internal, Source code, Update RSpec syntax
#8559) **Why**: NewRelic errors usually indicate direct user-facing problems, but this is a non-urgent warning to indicate cleanup changelog: Internal, Errors, Send email instead of alerting NewRelic for extra service providers
* Add doc_auth_agreement_controller_enabled feature flag changelog: Internal, Identity Verification, new Agreement Controller (feature flagged) * Add idv_consent_given field to idv_session and add check to hybrid_handoff_controller, leaving existing check in place. * Add new agreement routes * Initial controller, view, spec * Add feature specs * Add flow_session local, and go from Welcome to idv_agreement_url * Send params in controller update spec And leave name ial2_consent_given until after old AgreementStep is deleted * Redirect back to AgreementController from HybridHandoff * Redirect to same page on error to show error message * Add OutageConcern and before_action * Only mark complete for 50/50 state if actually complete
changelog: User-Facing Improvements, Sign In, Update layout of Sign In page to reflect results of recent A/B test
for new AgreementController specs [skip changelog]
changelog: Internal, Application dependencies, Enable postgis extension Adds the needed packages, migration, adapater, and updates documentation to use postgis. Also updates the Docker / CI settings. Co-authored-by: Matt Gardner <wilburnforce@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Paul Hirsch <59626817+pauldoomgov@users.noreply.github.com>
Prevent the user from uploading new documents after they've already submitted the verify info step For LG-9996 Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Doug Price <douglas.price@gsa.gov> changelog: Bug Fixes, Identity verification, Prevent user from uploading documents after submitting the verify info step.
* Use fixed argument to travel_to rather than Time.zone.now Because tests become flaky around midnight UTC which is 5pm PDT. [skip changelog] --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
changelog: User-Facing Improvements, Accessibility, Avoid duplicate announcement of radio label text
changelog: Internal, Identity Verification, add step indicator to new Agreement template
* Log redo_document_capture in document_capture_visited We want to log when redo_document_capture happens because it sometimes causes unexpected results for the user. When it was its own action it had its own analytics event, but now we are combining it with document_capture_visited. It will also be added to hybrid_handoff for users who are not on mobile. changelog: Internal, Identity verification logging, log redo_document_capture from document_capture and hybrid_handoff * Add redo_document_capture to hybrid_handoff_visited log * Check for new analytics param in redo_document_capture_action specs * refactor: use compact in #analytics_arguments --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
* Remove AnalyticsEvents include from spec Not sure why this was here. * Add timing to document upload requests Update the 'IdV: doc auth image upload vendor submitted' event to include vendor_request_time_in_ms so we can monitor whether long-running requests to doc auth vendors are actually succeeding or not. More context in this Slack thread: https://gsa-tts.slack.com/archives/C16RSBG49/p1686245549218449 changelog: Internal, Doc auth, Instrument document upload vendor requests * Fix ImageUploadsControllerSpec * Be more consistent - Check for Float, not just Numeric - Say a_kind_of instead of be_a_kind_of * Update app/forms/idv/api_image_upload_form.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Use keyword args for update_analytics --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal