Disable RSpec monkeypatching

[zachmargolis]

This is not urgent by any means, but it's something that was on my mind, so I figured I'd give converting our base a shot

• There's a few files I moved some examples to be indented/scoped, so I'd recommend ?w=1 to hide whitespace changes on this PR

Methodology:

git grep -l -E "^shared_examples" -- '*.rb'  | xargs perl -p -i -e 's/^shared_examples/RSpec.shared_examples/g'
git grep -l -E "^describe" -- '*.rb'  | xargs perl -p -i -e 's/^describe/RSpec.describe/g'
git grep -l -E "^feature" -- '*.rb'  | xargs perl -p -i -e 's/^feature/RSpec.feature/g' --            

[zachmargolis]

this is one of the files that got indented, recommend ?w=1 to see clearer version of changes here

[zachmargolis]

more info on this here: https://rubydoc.info/github/rspec/rspec-core/RSpec%2FCore%2FConfiguration:disable_monkey_patching!

[aduth]

Can you describe the motivation? Is it that the global methods are bad? 🤔

[zachmargolis]

Can you describe the motivation? Is it that the global methods are bad? 🤔

Yeah it's using an option to let RSpec be a "better-behaved" gem. Since this is in specs, not in prod, it's pretty minimal. It also made more of a difference with the old "should" style expectations, which relied a lot on monkeypatching (1.should eq 2) and the new "expect" expectations (expect(1).to eq(2)) already move away from a lot of those