Add location to events logged by promptOnNavigate#8550
Merged
Conversation
aduth
approved these changes
Jun 8, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I might worry about some naming consistency here, specifically:
- We use
locationas a way to describe a source element on the page from which a redirect event is initiated, which is a different type of value from a URL path (source) - In another place where we track a similar value, we call it
path(source)
Maybe calling it path instead?
matthinz
force-pushed
the
matthinz/onbeforeunload-logging-followup
branch
from
bdba3c4 to
9909541
Compare
Include _where_ the user was when they encountered an onbeforeunload popup. [skip changelog]
"location" is used more in the sense of "where on the page was this thing." Also, since we're not actually passing it as an option (or testing that), just always use window.location.pathname.
matthinz
force-pushed
the
matthinz/onbeforeunload-logging-followup
branch
from
9909541 to
b4632cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8512 I added some analytics to our
onbeforeunloadhandlers. Unfortunately, I neglected to augment the events to say where they were actually occurring (pathis always set to/api/loggerfor frontend events--I investigated fixing this for frontend events but it's a bigger lift than I'm looking for ATM).This PR just augments analytics events related to
onbeforeunloadwith alocationparameter (which defaults tolocation.pathname).