Merged
Conversation
aduth
reviewed
Jun 7, 2023
Contributor
There was a problem hiding this comment.
Not at all related to the scope of the ticket, but it occurs to me that document-capture-welcome's sole job is to add the skip_upload field, which is only used for the agreement step. So the script probably ought to be removed from the welcome step and renamed accordingly.
Contributor
Author
There was a problem hiding this comment.
I was eyeing that too. Thanks for confirming that it's now unused for welcome step. I'll rename either in this PR or separately.
Contributor
Author
There was a problem hiding this comment.
Added a note about renaming document-capture-welcome to LG-9367, because I'd rather make changes after this is fully deployed and the old AgreementStep is deleted.
soniaconnolly
force-pushed
the
sonia-lg-10016-agreement-controller
branch
from
b1193b3 to
1c15507
Compare
changelog: Internal, Identity Verification, new Agreement Controller (feature flagged)
and add check to hybrid_handoff_controller, leaving existing check in place.
And leave name ial2_consent_given until after old AgreementStep is deleted
soniaconnolly
force-pushed
the
sonia-lg-10016-agreement-controller
branch
from
7566ad7 to
b2d9637
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10016
🛠 Summary of changes
New AgreementController behind feature flag to replace FSM AgreementStep.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
doc_auth_agreement_controller_enabled: true/verify/verify/agreement/verify/agreement/verify/agreement👀 Screenshots
After: