Skip to content

Comments

Enable postgis extension#8536

Merged
night-jellyfish merged 8 commits intomainfrom
brittany/9416-enable-postgis-extension
Jun 9, 2023
Merged

Enable postgis extension#8536
night-jellyfish merged 8 commits intomainfrom
brittany/9416-enable-postgis-extension

Conversation

@night-jellyfish
Copy link
Contributor

@night-jellyfish night-jellyfish commented Jun 5, 2023

🎫 Ticket

LG-9416

🛠 Summary of changes

Adds the needed packages, migration, adapater, and updates documentation to use postgis.

📜 Testing Plan

  • Deploy to the Joy Sandbox environment
  • Follow the IPP flow all the way through
  • Troubleshoot any errors that crop up (hopefully none!)

@night-jellyfish
Copy link
Contributor Author

@pauldoomgov we'd especially appreciate if you could look this PR over and let us know if after approval and Joy Sandbox testing, if there's any additional work required to move these into the other environments.

In other words, should we be waiting or coordinating on anything,? Or, if everything goes well in the Sandbox, are we good to merge to main and go to prod?

Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity / learning, what drove you to check that? A possible error if it's already installed and we try to re-install it?

Copy link
Contributor

@mitchellhenke mitchellhenke Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, exactly. If for some reason the extension was already created, a "CREATE EXTENSION" without "IF NOT EXISTS" would raise an error. Mostly driven by past experiences in hand-writing migrations poorly 😀

@svalexander
Copy link
Contributor

all tests are failing in gitlab

@allthesignals
Copy link
Contributor

Try swapping that line for postgis/postgis:13-3.3 and maybe that'll make CI happy...

@allthesignals
Copy link
Contributor

The tests are failing because of the familiar error, "PG::UndefinedFile: ERROR: could not open extension control file," which is due to lack of PostGIS. I firmly believe swapping that line in the CI setup should address this!

@allthesignals allthesignals force-pushed the brittany/9416-enable-postgis-extension branch from 359ab03 to 48637bd Compare June 6, 2023 20:09
@night-jellyfish night-jellyfish force-pushed the brittany/9416-enable-postgis-extension branch from e9c1528 to b8f991a Compare June 7, 2023 15:33
Copy link
Contributor

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to use the same major version as we use in AuroraDB RDS.

@pauldoomgov
Copy link
Contributor

@night-jellyfish - There are no blockers on rolling this out. The PostGIS extension should be allowed and usable in all application environments.

@night-jellyfish night-jellyfish force-pushed the brittany/9416-enable-postgis-extension branch 2 times, most recently from 206b8e7 to e9c3a17 Compare June 9, 2023 19:24
Brittany Greaner and others added 8 commits June 9, 2023 15:47
Adds the needed packages, migration, adapater, and updates documentation
to use postgis.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Paul Hirsch <59626817+pauldoomgov@users.noreply.github.com>
@night-jellyfish night-jellyfish force-pushed the brittany/9416-enable-postgis-extension branch from e9c3a17 to 4a2b16e Compare June 9, 2023 20:47
@night-jellyfish night-jellyfish merged commit f081b1a into main Jun 9, 2023
@night-jellyfish night-jellyfish deleted the brittany/9416-enable-postgis-extension branch June 9, 2023 21:11
@jmhooper jmhooper mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants