Conversation
|
@pauldoomgov we'd especially appreciate if you could look this PR over and let us know if after approval and Joy Sandbox testing, if there's any additional work required to move these into the other environments. In other words, should we be waiting or coordinating on anything,? Or, if everything goes well in the Sandbox, are we good to merge to main and go to prod? Thank you! |
There was a problem hiding this comment.
wanted to double check, but it looks like this does do "IF NOT EXISTS":
https://github.com/rails/rails/blob/v7.0.5/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L433-L437
There was a problem hiding this comment.
Out of curiosity / learning, what drove you to check that? A possible error if it's already installed and we try to re-install it?
There was a problem hiding this comment.
Yep, exactly. If for some reason the extension was already created, a "CREATE EXTENSION" without "IF NOT EXISTS" would raise an error. Mostly driven by past experiences in hand-writing migrations poorly 😀
|
all tests are failing in gitlab |
|
Try swapping that line for postgis/postgis:13-3.3 and maybe that'll make CI happy... |
|
The tests are failing because of the familiar error, "PG::UndefinedFile: ERROR: could not open extension control file," which is due to lack of PostGIS. I firmly believe swapping that line in the CI setup should address this! |
359ab03 to
48637bd
Compare
e9c1528 to
b8f991a
Compare
pauldoomgov
left a comment
There was a problem hiding this comment.
One suggestion to use the same major version as we use in AuroraDB RDS.
|
@night-jellyfish - There are no blockers on rolling this out. The PostGIS extension should be allowed and usable in all application environments. |
206b8e7 to
e9c3a17
Compare
Adds the needed packages, migration, adapater, and updates documentation to use postgis.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Paul Hirsch <59626817+pauldoomgov@users.noreply.github.com>
e9c3a17 to
4a2b16e
Compare
🎫 Ticket
LG-9416
🛠 Summary of changes
Adds the needed packages, migration, adapater, and updates documentation to use postgis.
📜 Testing Plan