LG-8830 redo_document_capture logging#8581
Merged
soniaconnolly merged 5 commits intomainfrom Jun 12, 2023
Merged
Conversation
We want to log when redo_document_capture happens because it sometimes causes unexpected results for the user. When it was its own action it had its own analytics event, but now we are combining it with document_capture_visited. It will also be added to hybrid_handoff for users who are not on mobile. changelog: Internal, Identity verification logging, log redo_document_capture from document_capture and hybrid_handoff Co-authored-by: Douglas Price <douglas.price@gsa.gov>
…cument-capture-tracking
matthinz
reviewed
Jun 12, 2023
matthinz
reviewed
Jun 12, 2023
|
|
||
| args[:redo_document_capture] = true if params[:redo] | ||
|
|
||
| args |
matthinz
approved these changes
Jun 12, 2023
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
LGTM, just some nits on keeping those analytics_arguments methods looking a little nicer.
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8830
🛠 Summary of changes
Now that we don't have a separate RedoDocumentCaptureAction, log that the user is redoing document capture by adding params to the logging for the HybridHandoff and DocumentCapture steps.
We want to log when redo_document_capture happens because it sometimes causes unexpected results for the user. When it was its own action it had its own analytics event, but now we are combining it with document_capture_visited. It will also be added to hybrid_handoff for users who are not on mobile.