Add exception to sender_id requirement for Australia (AU)#8564
Merged
soniaconnolly merged 4 commits intomainfrom Jun 8, 2023
Merged
Add exception to sender_id requirement for Australia (AU)#8564soniaconnolly merged 4 commits intomainfrom
soniaconnolly merged 4 commits intomainfrom
Conversation
AWS updated their Supported countries and regions (SMS channel) to say that Australia needs sender ID, but we're not seeing that, so we are adding it to our list of SENDER_ID_COUNTRIES. https://docs.aws.amazon.com/pinpoint/latest/userguide/channels-sms-countries.html Co-authored-by: Gina Yamada <gina.yamada@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
We don't want to try to send a sender_id to a country where it is not registered. Co-authored-by: Zach Margolis <zach.margolis@gsa.gov> Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
zachmargolis
approved these changes
Jun 8, 2023
soniaconnolly
changed the title
Contributor
|
approved! |
Contributor
|
Nice, this is much better than just adding AU to the list and hoping for the best! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS updated their Supported countries and regions (SMS channel) to say that Australia needs sender ID, but we're not seeing that, so we are adding it to our list of SENDER_ID_COUNTRIES.
https://docs.aws.amazon.com/pinpoint/latest/userguide/channels-sms-countries.html